2022-01-16 01:03:58

by Corentin LABBE

Subject: [PATCH 1/2] ARM: dts: gemini: ns2502: permit to use gigabit

I believed that gigabit was not working due to some unknown missing GPIO.
In fact, gigabit worked when REALTEK_PHY was compiled out.
So the problem was due to PHY delay and we need to use rgmii-id.

Signed-off-by: Corentin Labbe <[email protected]>
---
arch/arm/boot/dts/gemini-ns2502.dts | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/gemini-ns2502.dts b/arch/arm/boot/dts/gemini-ns2502.dts
index 37e5debb693c..c759c4c732ab 100644
--- a/arch/arm/boot/dts/gemini-ns2502.dts
+++ b/arch/arm/boot/dts/gemini-ns2502.dts
@@ -39,10 +39,6 @@ mdio0: mdio {
phy0: ethernet-phy@1 {
reg = <1>;
device_type = "ethernet-phy";
- /* We lack the knowledge of necessary GPIO to achieve
- * Gigabit
- */
- max-speed = <100>;
};
};
};
@@ -50,7 +46,7 @@ phy0: ethernet-phy@1 {
&ethernet {
status = "okay";
ethernet-port@0 {
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-handle = <&phy0>;
mac-address = [00 1F 1F 8E 65 E2];
};
--
2.34.1

2022-01-16 01:04:41

by Corentin LABBE

Subject: [PATCH 2/2] ARM: dts: gemini: ssi1328: permit to use gigabit

I believed that gigabit was not working due to unknown missing GPIO.
But the problem was due to Marvell PHY incorrectly setting delay.
Now it is fixed, gigabit works.

Signed-off-by: Corentin Labbe <[email protected]>
---
arch/arm/boot/dts/gemini-ssi1328.dts | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/gemini-ssi1328.dts b/arch/arm/boot/dts/gemini-ssi1328.dts
index 113feb1c4922..bb85f1febe9d 100644
--- a/arch/arm/boot/dts/gemini-ssi1328.dts
+++ b/arch/arm/boot/dts/gemini-ssi1328.dts
@@ -40,10 +40,6 @@ mdio0: mdio {
phy0: ethernet-phy@1 {
reg = <1>;
device_type = "ethernet-phy";
- /* We lack the knowledge of necessary GPIO to achieve
- * Gigabit
- */
- max-speed = <100>;
};
/* WAN ICPlus IP101A */
phy1: ethernet-phy@2 {
--
2.34.1

2022-01-31 22:35:30

by Linus Walleij

Subject: Re: [PATCH 1/2] ARM: dts: gemini: ns2502: permit to use gigabit

On Sat, Jan 15, 2022 at 11:04 AM Corentin Labbe <[email protected]> wrote:

> I believed that gigabit was not working due to some unknown missing GPIO.
> In fact, gigabit worked when REALTEK_PHY was compiled out.
> So the problem was due to PHY delay and we need to use rgmii-id.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Thanks Corentin!

Patches applied.

Do you think I need a similar fix "rgmii"->"rgmii-id" on other
Gemini devicetrees that claim gigabit performance?

Yours,
Linus Walleij