2022-01-17 17:01:34

by CGEL

Subject: [PATCH] perf cpumap: remove duplicate include in cpumap.h

From: Lv Ruyi <[email protected]>

Remove all but the first include of stdbool.h from cpumap.h.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Lv Ruyi <[email protected]>
Signed-off-by: CGEL ZTE <[email protected]>
---
tools/perf/util/cpumap.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
index 0d3c2006a15d..240db1da370c 100644
--- a/tools/perf/util/cpumap.h
+++ b/tools/perf/util/cpumap.h
@@ -4,7 +4,6 @@

#include <stdbool.h>
#include <stdio.h>
-#include <stdbool.h>
#include <internal/cpumap.h>
#include <perf/cpumap.h>

--
2.25.1

2022-01-18 02:39:11

by Ian Rogers

Subject: Re: [PATCH] perf cpumap: remove duplicate include in cpumap.h

On Mon, Jan 17, 2022 at 12:37 AM <[email protected]> wrote:
>
> From: Lv Ruyi <[email protected]>
>
> Remove all but the first include of stdbool.h from cpumap.h.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Lv Ruyi <[email protected]>
> Signed-off-by: CGEL ZTE <[email protected]>

Acked-by: Ian Rogers <[email protected]>

Thanks,
Ian

> ---
> tools/perf/util/cpumap.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
> index 0d3c2006a15d..240db1da370c 100644
> --- a/tools/perf/util/cpumap.h
> +++ b/tools/perf/util/cpumap.h
> @@ -4,7 +4,6 @@
>
> #include <stdbool.h>
> #include <stdio.h>
> -#include <stdbool.h>
> #include <internal/cpumap.h>
> #include <perf/cpumap.h>
>
> --
> 2.25.1
>

2022-01-23 15:35:02

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf cpumap: remove duplicate include in cpumap.h

Em Mon, Jan 17, 2022 at 08:31:12AM -0800, Ian Rogers escreveu:
> On Mon, Jan 17, 2022 at 12:37 AM <[email protected]> wrote:
> >
> > From: Lv Ruyi <[email protected]>
> >
> > Remove all but the first include of stdbool.h from cpumap.h.
> >
> > Reported-by: Zeal Robot <[email protected]>
> > Signed-off-by: Lv Ruyi <[email protected]>
> > Signed-off-by: CGEL ZTE <[email protected]>
>
> Acked-by: Ian Rogers <[email protected]>

Thanks, applied.

- Arnaldo


> Thanks,
> Ian
>
> > ---
> > tools/perf/util/cpumap.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
> > index 0d3c2006a15d..240db1da370c 100644
> > --- a/tools/perf/util/cpumap.h
> > +++ b/tools/perf/util/cpumap.h
> > @@ -4,7 +4,6 @@
> >
> > #include <stdbool.h>
> > #include <stdio.h>
> > -#include <stdbool.h>
> > #include <internal/cpumap.h>
> > #include <perf/cpumap.h>
> >
> > --
> > 2.25.1
> >

--

- Arnaldo