2022-01-19 22:03:44

by CGEL

Subject: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable

From: Minghao Chi <[email protected]>

Return value from phy_read() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
Signed-off-by: CGEL ZTE <[email protected]>
---
drivers/net/phy/dp83640.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index c2d1a85ec559..4159e7cdc92c 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -226,15 +226,13 @@ static inline int broadcast_write(struct phy_device *phydev, u32 regnum,
static int ext_read(struct phy_device *phydev, int page, u32 regnum)
{
struct dp83640_private *dp83640 = phydev->priv;
- int val;

if (dp83640->clock->page != page) {
broadcast_write(phydev, PAGESEL, page);
dp83640->clock->page = page;
}
- val = phy_read(phydev, regnum);

- return val;
+ return phy_read(phydev, regnum);
}

/* Caller must hold extreg_lock. */
--
2.25.1

2022-01-20 14:25:22

by Richard Cochran

Subject: Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable

On Tue, Jan 18, 2022 at 07:54:38AM +0000, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Return value from phy_read() directly instead
> of taking this in another redundant variable.

NAK this is purely cosmetic and not clearly better WRT CodingStyle.

> Reported-by: Zeal Robot <[email protected]>

Please make your robot less zealous or filter its results before
posting.

This is the second time I told you. It isn't wise to ignore feedback,
and it is also rude.

Thanks,
Richard

2022-01-20 19:14:50

by Jakub Kicinski

Subject: Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable

On Tue, 18 Jan 2022 07:19:04 -0800 Richard Cochran wrote:
> On Tue, Jan 18, 2022 at 07:54:38AM +0000, [email protected] wrote:
> > From: Minghao Chi <[email protected]>
> >
> > Return value from phy_read() directly instead
> > of taking this in another redundant variable.
>
> NAK this is purely cosmetic and not clearly better WRT CodingStyle.
>
> > Reported-by: Zeal Robot <[email protected]>
>
> Please make your robot less zealous or filter its results before
> posting.

Plus what does it mean that the bot has signed this off?

> > Signed-off-by: CGEL ZTE <[email protected]>

> This is the second time I told you. It isn't wise to ignore feedback,
> and it is also rude.

Same, you don't reply to emails and keep making the same mistakes.

I asked you to realign the continuation lines in:
https://lore.kernel.org/all/20220112083942.391fd0d7@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net/
And without replying you just posted:
https://lore.kernel.org/all/[email protected]/