2022-01-24 08:46:41

by Frank Wunderlich

Subject: [PATCH v1] arm64: dts: rk356x: fix dma-controller warning

From: Frank Wunderlich <[email protected]>

DMA-Cotrollers defined in rk356x.dtsi do not match the pattern in bindings.

arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml:
dmac@fe530000: $nodename:0: 'dmac@fe530000' does not match '^dma-controller(@.*)?$'
From schema: Documentation/devicetree/bindings/dma/arm,pl330.yaml
arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml:
dmac@fe550000: $nodename:0: 'dmac@fe550000' does not match '^dma-controller(@.*)?$'
From schema: Documentation/devicetree/bindings/dma/arm,pl330.yaml

This Patch fixes it.

Signed-off-by: Frank Wunderlich <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index a68033a23975..8ccce54ee8e7 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -651,7 +651,7 @@ &i2s1m0_sdo0 &i2s1m0_sdo1
status = "disabled";
};

- dmac0: dmac@fe530000 {
+ dmac0: dma-controller@fe530000 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x0 0xfe530000 0x0 0x4000>;
interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
@@ -662,7 +662,7 @@ dmac0: dmac@fe530000 {
#dma-cells = <1>;
};

- dmac1: dmac@fe550000 {
+ dmac1: dma-controller@fe550000 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x0 0xfe550000 0x0 0x4000>;
interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
--
2.25.1

2022-01-24 09:44:10

by Heiko Stuebner

Subject: Re: [PATCH v1] arm64: dts: rk356x: fix dma-controller warning

On Sun, 23 Jan 2022 14:36:15 +0100, Frank Wunderlich wrote:
> DMA-Cotrollers defined in rk356x.dtsi do not match the pattern in bindings.
>
> arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml:
> dmac@fe530000: $nodename:0: 'dmac@fe530000' does not match '^dma-controller(@.*)?$'
> From schema: Documentation/devicetree/bindings/dma/arm,pl330.yaml
> arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml:
> dmac@fe550000: $nodename:0: 'dmac@fe550000' does not match '^dma-controller(@.*)?$'
> From schema: Documentation/devicetree/bindings/dma/arm,pl330.yaml
>
> [...]

Applied as fix for 5.17, thanks!

[1/1] arm64: dts: rk356x: fix dma-controller warning
commit: 2ddd96aadbd0412040ef49eda94549c32de6c92c

I've adapted the subject to
arm64: dts: rockchip: fix dma-controller node names on rk356x
though. Please use prefixes matching the subsystem
(i.e. arm64: dts: rockchip: ... in this case)

Best regards,
--
Heiko Stuebner <[email protected]>