2022-01-11 01:57:28

by CGEL

Subject: [PATCH] fs/btrfs: remove redundant ret variable

From: Minghao Chi <[email protected]>

Return value from fs_path_add_path() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
Signed-off-by: CGEL ZTE <[email protected]>
---
fs/btrfs/send.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 3fc144b8c0d8..4ed13461cb07 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -528,14 +528,10 @@ static int fs_path_add_from_extent_buffer(struct fs_path *p,

static int fs_path_copy(struct fs_path *p, struct fs_path *from)
{
- int ret;
-
p->reversed = from->reversed;
fs_path_reset(p);

- ret = fs_path_add_path(p, from);
-
- return ret;
+ return fs_path_add_path(p, from);
}


--
2.25.1

2022-01-11 07:13:05

by Nikolay Borisov

Subject: Re: [PATCH] fs/btrfs: remove redundant ret variable

On 11.01.22 г. 3:57, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Return value from fs_path_add_path() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> Signed-off-by: CGEL ZTE <[email protected]>

Reviewed-by: Nikolay Borisov <[email protected]>

<snip>

2022-01-24 21:14:38

by David Sterba

Subject: Re: [PATCH] fs/btrfs: remove redundant ret variable

On Tue, Jan 11, 2022 at 01:57:16AM +0000, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Return value from fs_path_add_path() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> Signed-off-by: CGEL ZTE <[email protected]>

Added to misc-next, thanks.