From: Guochun Mao <[email protected]>
Variables mtk_nor_caps_mt8173, mtk_nor_caps_mt8186 and
mtk_nor_caps_mt8192 are not declared.
Make them static.
Fixes: 5b177234e9fd ("spi: spi-mtk-nor: improve device table for adding more capabilities")
Signed-off-by: Guochun Mao <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
drivers/spi/spi-mtk-nor.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-mtk-nor.c b/drivers/spi/spi-mtk-nor.c
index 455b4dcb26e9..94fb09696677 100644
--- a/drivers/spi/spi-mtk-nor.c
+++ b/drivers/spi/spi-mtk-nor.c
@@ -770,17 +770,17 @@ static const struct spi_controller_mem_ops mtk_nor_mem_ops = {
.exec_op = mtk_nor_exec_op
};
-const struct mtk_nor_caps mtk_nor_caps_mt8173 = {
+static const struct mtk_nor_caps mtk_nor_caps_mt8173 = {
.dma_bits = 32,
.extra_dummy_bit = 0,
};
-const struct mtk_nor_caps mtk_nor_caps_mt8186 = {
+static const struct mtk_nor_caps mtk_nor_caps_mt8186 = {
.dma_bits = 32,
.extra_dummy_bit = 1,
};
-const struct mtk_nor_caps mtk_nor_caps_mt8192 = {
+static const struct mtk_nor_caps mtk_nor_caps_mt8192 = {
.dma_bits = 36,
.extra_dummy_bit = 0,
};
--
2.25.1
On Wed, 26 Jan 2022 17:11:59 +0800, [email protected] wrote:
> From: Guochun Mao <[email protected]>
>
> Variables mtk_nor_caps_mt8173, mtk_nor_caps_mt8186 and
> mtk_nor_caps_mt8192 are not declared.
> Make them static.
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: spi-mtk-nor: make some internal variables static
commit: 474fc2e6395d62758e80b9ea65f61339296355fc
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
Il 26/01/22 10:11, [email protected] ha scritto:
> From: Guochun Mao <[email protected]>
>
> Variables mtk_nor_caps_mt8173, mtk_nor_caps_mt8186 and
> mtk_nor_caps_mt8192 are not declared.
> Make them static.
>
> Fixes: 5b177234e9fd ("spi: spi-mtk-nor: improve device table for adding more capabilities")
> Signed-off-by: Guochun Mao <[email protected]>
> Reported-by: kernel test robot <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Hi,
Thank you very much.
BR,
Guochun
On Wed, 2022-01-26 at 15:36 +0000, Mark Brown wrote:
> On Wed, 26 Jan 2022 17:11:59 +0800, [email protected] wrote:
> > From: Guochun Mao <[email protected]>
> >
> > Variables mtk_nor_caps_mt8173, mtk_nor_caps_mt8186 and
> > mtk_nor_caps_mt8192 are not declared.
> > Make them static.
> >
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
> for-next
>
> Thanks!
>
> [1/1] spi: spi-mtk-nor: make some internal variables static
> commit: 474fc2e6395d62758e80b9ea65f61339296355fc
>
> All being well this means that it will be integrated into the linux-
> next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual
> testing
> and review of the tree, please engage with people reporting problems
> and
> send followup patches addressing any issues that are reported if
> needed.
>
> If any updates are required or you are submitting further changes
> they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when
> replying
> to this mail.
>
> Thanks,
> Mark