2022-02-22 14:07:35

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [RFT PATCH 1/3] clk: imx: scu: fix kfree() of const memory on setting driver_override

The driver_override field from platform driver should not be initialized
from const memory because the core later kfree() it, for example when
driver_override is set via sysfs.

Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support")
Cc: <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/clk/imx/clk-scu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
index 083da31dc3ea..78ed40a0e3e2 100644
--- a/drivers/clk/imx/clk-scu.c
+++ b/drivers/clk/imx/clk-scu.c
@@ -683,7 +683,11 @@ struct clk_hw *imx_clk_scu_alloc_dev(const char *name,
return ERR_PTR(ret);
}

- pdev->driver_override = "imx-scu-clk";
+ pdev->driver_override = kstrdup("imx-scu-clk", GFP_KERNEL);
+ if (!pdev->driver_override) {
+ platform_device_put(pdev);
+ return ERR_PTR(-ENOMEM);
+ }

ret = imx_clk_scu_attach_pd(&pdev->dev, rsrc_id);
if (ret)
--
2.32.0