2022-02-25 16:14:18

by Jérôme Pouiller

[permalink] [raw]
Subject: [PATCH 00/10] staging: wfx: usual maintenance

From: Jérôme Pouiller <[email protected]>

This PR contains fixes for various small defects I have seen these last
weeks.

Jérôme Pouiller (10):
staging: wfx: sta.o was linked twice
staging: wfx: fix struct alignment
staging: wfx: format comments on 100 columns
staging: wfx: format code on 100 columns
staging: wfx: remove useless variable
staging: wfx: drop useless include
staging: wfx: remove duplicated code in wfx_cmd_send()
staging: wfx: prefer to wait for an event instead to sleep
staging: wfx: ensure HIF request has been sent before polling
staging: wfx: flags for SPI IRQ were ignored

drivers/staging/wfx/Makefile | 1 -
drivers/staging/wfx/bh.c | 1 +
drivers/staging/wfx/bus_spi.c | 30 +++++++++++++++---------------
drivers/staging/wfx/data_tx.c | 8 ++------
drivers/staging/wfx/fwio.c | 3 +--
drivers/staging/wfx/hif_api_cmd.h | 2 --
drivers/staging/wfx/hif_rx.c | 3 +--
drivers/staging/wfx/hif_tx.c | 13 ++++++-------
drivers/staging/wfx/hif_tx_mib.c | 3 +--
drivers/staging/wfx/hwio.c | 9 +++------
drivers/staging/wfx/queue.c | 9 ++++-----
drivers/staging/wfx/sta.c | 11 +++++------
drivers/staging/wfx/sta.h | 3 +--
13 files changed, 40 insertions(+), 56 deletions(-)

--
2.34.1


2022-02-25 17:14:44

by Jérôme Pouiller

[permalink] [raw]
Subject: [PATCH 10/10] staging: wfx: flags for SPI IRQ were ignored

From: Jérôme Pouiller <[email protected]>

The flags declared in the DT were not forwarded to request_irq().

Fixes: a7efb62509d8 ("staging: wfx: use threaded IRQ with SPI")
Signed-off-by: Jérôme Pouiller <[email protected]>
---
drivers/staging/wfx/bus_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wfx/bus_spi.c b/drivers/staging/wfx/bus_spi.c
index a0a98c074cb5..bb31f8a005bf 100644
--- a/drivers/staging/wfx/bus_spi.c
+++ b/drivers/staging/wfx/bus_spi.c
@@ -162,7 +162,7 @@ static int wfx_spi_irq_subscribe(void *priv)
flags = IRQF_TRIGGER_HIGH;
flags |= IRQF_ONESHOT;
return devm_request_threaded_irq(&bus->func->dev, bus->func->irq, NULL,
- wfx_spi_irq_handler, IRQF_ONESHOT, "wfx", bus);
+ wfx_spi_irq_handler, flags, "wfx", bus);
}

static int wfx_spi_irq_unsubscribe(void *priv)
--
2.34.1