2022-03-01 17:01:13

by Vincent Whitchurch

Subject: [PATCH] pstore: Add prefix to ECC messages

The "No errors detected" message from the ECC code is shown at the end
of the pstore log and can be confusing or misleading, especially since
it usually appears just after a kernel crash log which normally means
quite the opposite of "no errors". Prefix the message to clarify that
this message is only about ECC-detected errors.

Signed-off-by: Vincent Whitchurch <[email protected]>
---
fs/pstore/ram_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index fe5305028c6e..a89e33719fcf 100644
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -263,10 +263,10 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz,

if (prz->corrected_bytes || prz->bad_blocks)
ret = snprintf(str, len, ""
- "\n%d Corrected bytes, %d unrecoverable blocks\n",
+ "\nECC: %d Corrected bytes, %d unrecoverable blocks\n",
prz->corrected_bytes, prz->bad_blocks);
else
- ret = snprintf(str, len, "\nNo errors detected\n");
+ ret = snprintf(str, len, "\nECC: No errors detected\n");

return ret;
}
--
2.34.1

2022-03-01 20:24:44

by Kees Cook

Subject: Re: [PATCH] pstore: Add prefix to ECC messages

On Tue, 1 Mar 2022 15:49:32 +0100, Vincent Whitchurch wrote:
> The "No errors detected" message from the ECC code is shown at the end
> of the pstore log and can be confusing or misleading, especially since
> it usually appears just after a kernel crash log which normally means
> quite the opposite of "no errors". Prefix the message to clarify that
> this message is only about ECC-detected errors.
>
>
> [...]

Excellent point. :)

Applied to for-next/pstore, thanks!

[1/1] pstore: Add prefix to ECC messages
https://git.kernel.org/kees/c/023bbde3db41

--
Kees Cook