2022-02-28 10:49:34

by Hangyu Hua

Subject: [PATCH] mips: ralink: fix a refcount leak in ill_acc_of_setup()

of_node_put(np) needs to be called when pdev == NULL.

Signed-off-by: Hangyu Hua <[email protected]>
---
arch/mips/ralink/ill_acc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/mips/ralink/ill_acc.c b/arch/mips/ralink/ill_acc.c
index 115a69fc20ca..f395ae218470 100644
--- a/arch/mips/ralink/ill_acc.c
+++ b/arch/mips/ralink/ill_acc.c
@@ -61,6 +61,7 @@ static int __init ill_acc_of_setup(void)
pdev = of_find_device_by_node(np);
if (!pdev) {
pr_err("%pOFn: failed to lookup pdev\n", np);
+ of_node_put(np);
return -EINVAL;
}

--
2.25.1

2022-03-02 02:31:01

by Thomas Bogendoerfer

Subject: Re: [PATCH] mips: ralink: fix a refcount leak in ill_acc_of_setup()

On Mon, Feb 28, 2022 at 03:35:37PM +0800, Hangyu Hua wrote:
> of_node_put(np) needs to be called when pdev == NULL.
>
> Signed-off-by: Hangyu Hua <[email protected]>
> ---
> arch/mips/ralink/ill_acc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/ralink/ill_acc.c b/arch/mips/ralink/ill_acc.c
> index 115a69fc20ca..f395ae218470 100644
> --- a/arch/mips/ralink/ill_acc.c
> +++ b/arch/mips/ralink/ill_acc.c
> @@ -61,6 +61,7 @@ static int __init ill_acc_of_setup(void)
> pdev = of_find_device_by_node(np);
> if (!pdev) {
> pr_err("%pOFn: failed to lookup pdev\n", np);
> + of_node_put(np);
> return -EINVAL;
> }
>
> --
> 2.25.1

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]