2022-03-04 14:29:48

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH net-next 0/3] Add support for 1588 in LAN8814

On Fri, Mar 04, 2022 at 01:21:21PM +0000, David Miller wrote:
> From: Andrew Lunn <[email protected]>
> Date: Fri, 4 Mar 2022 14:06:54 +0100
>
> > On Fri, Mar 04, 2022 at 12:50:11PM +0000, [email protected] wrote:
> >> Hello:
> >>
> >> This series was applied to netdev/net-next.git (master)
> >> by David S. Miller <[email protected]>:
> >
> > Hi David
> >
> > Why was this merged?
>
> Sorry, it seemed satraightforward to me, and I try to get the backlog under 40 patches before
> I hand over to Jakub for the day.
>
> If you want to review, reply to the thread immediately saying so, don't wait until you haver time for the
> full review.

This patchset was on the list for less than 5 hours before it got
merged. I tend to sleep for 8 to 10 hours. Making it impossible for me
to react any faster. At an absolute minimum, you need to wait 12
hours, if you expect anybody to have a fair chance of being able to
say, hold on, i want to comment on this patchset.

I also don't like the metric of 40 patches backlog. Is the size of
backlog more important than the quality of the patches? Don't we care
about the quality of the code any more? Don't we care about getting
code reviewed any more?

Andrew


2022-03-04 19:36:35

by David Miller

[permalink] [raw]
Subject: Re: [PATCH net-next 0/3] Add support for 1588 in LAN8814

From: Andrew Lunn <[email protected]>
Date: Fri, 4 Mar 2022 14:47:48 +0100

> On Fri, Mar 04, 2022 at 01:21:21PM +0000, David Miller wrote:
>> From: Andrew Lunn <[email protected]>
>> Date: Fri, 4 Mar 2022 14:06:54 +0100
>>
>> > On Fri, Mar 04, 2022 at 12:50:11PM +0000, [email protected] wrote:
>> >> Hello:
>> >>
>> >> This series was applied to netdev/net-next.git (master)
>> >> by David S. Miller <[email protected]>:
>> >
>> > Hi David
>> >
>> > Why was this merged?
>>
>> Sorry, it seemed satraightforward to me, and I try to get the backlog under 40 patches before
>> I hand over to Jakub for the day.
>>
>> If you want to review, reply to the thread immediately saying so, don't wait until you haver time for the
>> full review.
>
> This patchset was on the list for less than 5 hours before it got
> merged. I tend to sleep for 8 to 10 hours. Making it impossible for me
> to react any faster. At an absolute minimum, you need to wait 12
> hours, if you expect anybody to have a fair chance of being able to
> say, hold on, i want to comment on this patchset.
>
> I also don't like the metric of 40 patches backlog. Is the size of
> backlog more important than the quality of the patches? Don't we care
> about the quality of the code any more? Don't we care about getting
> code reviewed any more?

Ok, message received, I'll apply things less aggressively.

Thank you.