Hello, this is the v2 for my set of patches :
- use dev_err_probe() instead of dev_err() in the newvision panel
driver probe function
- add bindings documentation for the Leadtek ltk035c5444t
Cheers - Christophe
------------------------
Hello, this is a set of patches to allow the upstreaming of the
NV3052C panel found in the Anbernic RG350M mips gaming handheld.
It was never upstreamed so far due to a longstanding graphical
bug, which I propose to solve by introducing ingenic_drm_bridge_atomic_enable
in the drm driver so the CRTC can be enabled after the panel itself slept
out, and not before as it used to.
After the drm change, 2 of the existing panels have to be modified accordingly
to introduce missing .enable and .disable in their code.
Christophe Branchereau (4):
drm/ingenic : add ingenic_drm_bridge_atomic_enable
drm/panel: Add panel driver for NewVision NV3052C based LCDs
drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and
.disable
dt-bindings: display/panel: Add Leadtek ltk035c5444t
.../panel/leadtek,ltk035c5444t-spi.yaml | 59 +++
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +-
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 23 +-
drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 +-
.../gpu/drm/panel/panel-newvision-nv3052c.c | 497 ++++++++++++++++++
7 files changed, 627 insertions(+), 12 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c
--
2.34.1
This allows the CRTC to be enabled after panels have slept out,
and before their display is turned on, solving a graphical bug
on the newvision nv3502c
Signed-off-by: Christophe Branchereau <[email protected]>
---
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index dcf44cb00821..51512f41263e 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct notifier_block *nb,
}
}
+static void ingenic_drm_bridge_atomic_enable(struct drm_bridge *bridge,
+ struct drm_bridge_state *old_bridge_state)
+{
+ struct ingenic_drm *priv = drm_device_get_priv(bridge->dev);
+
+ regmap_write(priv->map, JZ_REG_LCD_STATE, 0);
+
+ regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
+ JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE,
+ JZ_LCD_CTRL_ENABLE);
+}
+
static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,
struct drm_atomic_state *state)
{
@@ -237,17 +249,11 @@ static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,
if (WARN_ON(IS_ERR(priv_state)))
return;
- regmap_write(priv->map, JZ_REG_LCD_STATE, 0);
-
/* Set addresses of our DMA descriptor chains */
next_id = priv_state->use_palette ? HWDESC_PALETTE : 0;
regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, next_id));
regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1));
- regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
- JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE,
- JZ_LCD_CTRL_ENABLE);
-
drm_crtc_vblank_on(crtc);
}
@@ -968,6 +974,7 @@ static const struct drm_encoder_helper_funcs ingenic_drm_encoder_helper_funcs =
static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = {
.attach = ingenic_drm_bridge_attach,
+ .atomic_enable = ingenic_drm_bridge_atomic_enable,
.atomic_check = ingenic_drm_bridge_atomic_check,
.atomic_reset = drm_atomic_helper_bridge_reset,
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
--
2.34.1
Add binding for the leadtek ltk035c5444t, which is a 640x480
mipi-dbi over spi / 24-bit RGB panel based on the newvision
NV03052C chipset.
It is found in the Anbernic RG350M mips handheld.
Signed-off-by: Christophe Branchereau <[email protected]>
---
.../panel/leadtek,ltk035c5444t-spi.yaml | 59 +++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
new file mode 100644
index 000000000000..9b6f1810adab
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/leadtek,ltk035c5444t-spi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Leadtek ltk035c5444t 3.5" (640x480 pixels) 24-bit IPS LCD panel
+
+maintainers:
+ - Paul Cercueil <[email protected]>
+ - Christophe Branchereau <[email protected]>
+
+allOf:
+ - $ref: panel-common.yaml#
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+ compatible:
+ const: leadtek,ltk035c5444t-spi
+
+ backlight: true
+ port: true
+ power-supply: true
+ reg: true
+ reset-gpios: true
+
+required:
+ - compatible
+ - power-supply
+ - reset-gpios
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ panel@0 {
+ compatible = "leadtek,ltk035c5444t-spi";
+ reg = <0>;
+
+ spi-3wire;
+ spi-max-frequency = <3125000>;
+
+ reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
+
+ backlight = <&backlight>;
+ power-supply = <&vcc>;
+
+ port {
+ panel_input: endpoint {
+ remote-endpoint = <&panel_output>;
+ };
+ };
+ };
+ };
--
2.34.1
On Tue, Mar 08, 2022 at 02:06:43PM +0100, Christophe Branchereau wrote:
> Add binding for the leadtek ltk035c5444t, which is a 640x480
> mipi-dbi over spi / 24-bit RGB panel based on the newvision
> NV03052C chipset.
>
> It is found in the Anbernic RG350M mips handheld.
>
> Signed-off-by: Christophe Branchereau <[email protected]>
> ---
> .../panel/leadtek,ltk035c5444t-spi.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
We have 18 SPI based panels already:
$ git grep -i 'spi.* {' Documentation/devicetree/bindings/display/panel/
Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml: spi {
Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml: spi {
Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml: spi {
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml: spi {
Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml: spi {
Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml: spi {
Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml: spi {
Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml: spi {
Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml: spi0 {
Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml: spi {
Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml: spi {
Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml: spi {
Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml: spi {
Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml: spi {
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml: spi {
Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml: spi {
Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi {
Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml: spi {
Most except for the Samsung ones look like they'd fit in our definition
of 'simple panels' which primarily means 1 supply.
So I think it is time for a panel-simple-spi.yaml binding to combine all
these. But I'm not going to make the person adding the 19th case to do
that, and this otherwise looks fine:
Reviewed-by: Rob Herring <[email protected]>
With one nit fixed below:
>
> diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
> new file mode 100644
> index 000000000000..9b6f1810adab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/leadtek,ltk035c5444t-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Leadtek ltk035c5444t 3.5" (640x480 pixels) 24-bit IPS LCD panel
> +
> +maintainers:
> + - Paul Cercueil <[email protected]>
> + - Christophe Branchereau <[email protected]>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + const: leadtek,ltk035c5444t-spi
'-spi' is redundant, so drop.
> +
> + backlight: true
> + port: true
> + power-supply: true
> + reg: true
> + reset-gpios: true
> +
> +required:
> + - compatible
> + - power-supply
> + - reset-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel@0 {
> + compatible = "leadtek,ltk035c5444t-spi";
And update the example...
> + reg = <0>;
> +
> + spi-3wire;
> + spi-max-frequency = <3125000>;
> +
> + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
> +
> + backlight = <&backlight>;
> + power-supply = <&vcc>;
> +
> + port {
> + panel_input: endpoint {
> + remote-endpoint = <&panel_output>;
> + };
> + };
> + };
> + };
> --
> 2.34.1
>
>
Hi Rob,
Le jeu., mars 10 2022 at 16:30:26 -0600, Rob Herring <[email protected]>
a ?crit :
> On Tue, Mar 08, 2022 at 02:06:43PM +0100, Christophe Branchereau
> wrote:
>> Add binding for the leadtek ltk035c5444t, which is a 640x480
>> mipi-dbi over spi / 24-bit RGB panel based on the newvision
>> NV03052C chipset.
>>
>> It is found in the Anbernic RG350M mips handheld.
>>
>> Signed-off-by: Christophe Branchereau <[email protected]>
>> ---
>> .../panel/leadtek,ltk035c5444t-spi.yaml | 59
>> +++++++++++++++++++
>> 1 file changed, 59 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
>
> We have 18 SPI based panels already:
>
> $ git grep -i 'spi.* {'
> Documentation/devicetree/bindings/display/panel/
> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml:
> spi0 {
> Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml:
> spi {
> Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi {
> Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml:
> spi {
>
> Most except for the Samsung ones look like they'd fit in our
> definition
> of 'simple panels' which primarily means 1 supply.
>
> So I think it is time for a panel-simple-spi.yaml binding to combine
> all
> these. But I'm not going to make the person adding the 19th case to do
> that, and this otherwise looks fine:
>
> Reviewed-by: Rob Herring <[email protected]>
I actually thought you sent a patch for this already (I remember you
talking about it last a binding for a new SPI panel has been added).
I will work on it next week - provided Cristophe's patch has been
merged before.
Cheers,
-Paul
>
> With one nit fixed below:
>
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
>> b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
>> new file mode 100644
>> index 000000000000..9b6f1810adab
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
>> @@ -0,0 +1,59 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:
>> http://devicetree.org/schemas/display/panel/leadtek,ltk035c5444t-spi.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Leadtek ltk035c5444t 3.5" (640x480 pixels) 24-bit IPS LCD
>> panel
>> +
>> +maintainers:
>> + - Paul Cercueil <[email protected]>
>> + - Christophe Branchereau <[email protected]>
>> +
>> +allOf:
>> + - $ref: panel-common.yaml#
>> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: leadtek,ltk035c5444t-spi
>
> '-spi' is redundant, so drop.
>
>> +
>> + backlight: true
>> + port: true
>> + power-supply: true
>> + reg: true
>> + reset-gpios: true
>> +
>> +required:
>> + - compatible
>> + - power-supply
>> + - reset-gpios
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + spi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + panel@0 {
>> + compatible = "leadtek,ltk035c5444t-spi";
>
> And update the example...
>
>> + reg = <0>;
>> +
>> + spi-3wire;
>> + spi-max-frequency = <3125000>;
>> +
>> + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
>> +
>> + backlight = <&backlight>;
>> + power-supply = <&vcc>;
>> +
>> + port {
>> + panel_input: endpoint {
>> + remote-endpoint = <&panel_output>;
>> + };
>> + };
>> + };
>> + };
>> --
>> 2.34.1
>>
>>
On Fri, Mar 11, 2022 at 7:05 AM Paul Cercueil <[email protected]> wrote:
>
> Hi Rob,
>
> Le jeu., mars 10 2022 at 16:30:26 -0600, Rob Herring <[email protected]>
> a écrit :
> > On Tue, Mar 08, 2022 at 02:06:43PM +0100, Christophe Branchereau
> > wrote:
> >> Add binding for the leadtek ltk035c5444t, which is a 640x480
> >> mipi-dbi over spi / 24-bit RGB panel based on the newvision
> >> NV03052C chipset.
> >>
> >> It is found in the Anbernic RG350M mips handheld.
> >>
> >> Signed-off-by: Christophe Branchereau <[email protected]>
> >> ---
> >> .../panel/leadtek,ltk035c5444t-spi.yaml | 59
> >> +++++++++++++++++++
> >> 1 file changed, 59 insertions(+)
> >> create mode 100644
> >> Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
> >
> > We have 18 SPI based panels already:
> >
> > $ git grep -i 'spi.* {'
> > Documentation/devicetree/bindings/display/panel/
> > Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml:
> > spi0 {
> > Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi {
> > Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml:
> > spi {
> >
> > Most except for the Samsung ones look like they'd fit in our
> > definition
> > of 'simple panels' which primarily means 1 supply.
> >
> > So I think it is time for a panel-simple-spi.yaml binding to combine
> > all
> > these. But I'm not going to make the person adding the 19th case to do
> > that, and this otherwise looks fine:
> >
> > Reviewed-by: Rob Herring <[email protected]>
>
> I actually thought you sent a patch for this already (I remember you
> talking about it last a binding for a new SPI panel has been added).
It was just adding spi-peripheral-props.yaml reference that I sent.
> I will work on it next week - provided Cristophe's patch has been
> merged before.
Thanks!
Rob