2022-03-17 04:40:09

by Bjorn Andersson

Subject: [PATCH] thermal/drivers/qcom/lmh: Fix irq handler return value

After enough invocations the LMh irq is eventually reported as bad, because the
handler doesn't return IRQ_HANDLED, fix this.

Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver")
Reported-by: Daniel Lezcano <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/thermal/qcom/lmh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c
index c7f91cbdccc7..af9f0872614f 100644
--- a/drivers/thermal/qcom/lmh.c
+++ b/drivers/thermal/qcom/lmh.c
@@ -45,7 +45,7 @@ static irqreturn_t lmh_handle_irq(int hw_irq, void *data)
if (irq)
generic_handle_irq(irq);

- return 0;
+ return IRQ_HANDLED;
}

static void lmh_enable_interrupt(struct irq_data *d)
--
2.33.1

2022-03-17 06:28:11

by Dmitry Baryshkov

Subject: Re: [PATCH] thermal/drivers/qcom/lmh: Fix irq handler return value

On Wed, 16 Mar 2022 at 21:01, Bjorn Andersson
<[email protected]> wrote:
>
> After enough invocations the LMh irq is eventually reported as bad, because the
> handler doesn't return IRQ_HANDLED, fix this.
>
> Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver")
> Reported-by: Daniel Lezcano <[email protected]>
> Signed-off-by: Bjorn Andersson <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>

> ---
> drivers/thermal/qcom/lmh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c
> index c7f91cbdccc7..af9f0872614f 100644
> --- a/drivers/thermal/qcom/lmh.c
> +++ b/drivers/thermal/qcom/lmh.c
> @@ -45,7 +45,7 @@ static irqreturn_t lmh_handle_irq(int hw_irq, void *data)
> if (irq)
> generic_handle_irq(irq);
>
> - return 0;
> + return IRQ_HANDLED;
> }
>
> static void lmh_enable_interrupt(struct irq_data *d)
> --
> 2.33.1
>


--
With best wishes
Dmitry