2022-03-17 16:50:25

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX

If MAILBOX is n, building fails:

drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'

Make QCOM_MPM depends on MAILBOX to fix this.

Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 680d2fcf2686..15edb9a6fcae 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -433,6 +433,7 @@ config QCOM_PDC
config QCOM_MPM
tristate "QCOM MPM"
depends on ARCH_QCOM
+ depends on MAILBOX
select IRQ_DOMAIN_HIERARCHY
help
MSM Power Manager driver to manage and configure wakeup
--
2.17.1


2022-03-17 17:09:38

by Marc Zyngier

[permalink] [raw]
Subject: Re: [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX

On 2022-03-17 13:59, Shawn Guo wrote:
> On Thu, Mar 17, 2022 at 09:19:56PM +0800, YueHaibing wrote:
>> If MAILBOX is n, building fails:
>>
>> drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
>> irq-qcom-mpm.c:(.text+0x174): undefined reference to
>> `mbox_send_message'
>> irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit:
>> R_AARCH64_CALL26 against undefined symbol `mbox_send_message'
>>
>> Make QCOM_MPM depends on MAILBOX to fix this.
>>
>> Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
>> Signed-off-by: YueHaibing <[email protected]>
>
> Acked-by: Shawn Guo <[email protected]>
>
>> ---
>> drivers/irqchip/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 680d2fcf2686..15edb9a6fcae 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -433,6 +433,7 @@ config QCOM_PDC
>> config QCOM_MPM
>> tristate "QCOM MPM"
>> depends on ARCH_QCOM
>> + depends on MAILBOX
>> select IRQ_DOMAIN_HIERARCHY
>> help
>> MSM Power Manager driver to manage and configure wakeup
>> --
>> 2.17.1
>>

Hmmm... Even if that fix the build, this still isn't correct, is it?
You also need the mailbox *driver* to be selected. How is that
dependency enforced?

I'll queue this to fix -next, but this really is papering over
a bigger problem.

M.
--
Jazz is not dead. It just smells funny...

Subject: [irqchip: irq/irqchip-next] irq/qcom-mpm: Fix build error without MAILBOX

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID: 8f887b78961c935a54bb2b5d4dc2c25f869c3723
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/8f887b78961c935a54bb2b5d4dc2c25f869c3723
Author: YueHaibing <[email protected]>
AuthorDate: Thu, 17 Mar 2022 21:19:56 +08:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Thu, 17 Mar 2022 15:29:04

irq/qcom-mpm: Fix build error without MAILBOX

If MAILBOX is n, building fails:

drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'

Make QCOM_MPM depends on MAILBOX to fix this.

Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
Signed-off-by: YueHaibing <[email protected]>
Acked-by: Shawn Guo <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 680d2fc..15edb9a 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -433,6 +433,7 @@ config QCOM_PDC
config QCOM_MPM
tristate "QCOM MPM"
depends on ARCH_QCOM
+ depends on MAILBOX
select IRQ_DOMAIN_HIERARCHY
help
MSM Power Manager driver to manage and configure wakeup

2022-03-17 20:50:31

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX

On Thu, Mar 17, 2022 at 09:19:56PM +0800, YueHaibing wrote:
> If MAILBOX is n, building fails:
>
> drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
> irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
> irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'
>
> Make QCOM_MPM depends on MAILBOX to fix this.
>
> Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
> Signed-off-by: YueHaibing <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> drivers/irqchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 680d2fcf2686..15edb9a6fcae 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -433,6 +433,7 @@ config QCOM_PDC
> config QCOM_MPM
> tristate "QCOM MPM"
> depends on ARCH_QCOM
> + depends on MAILBOX
> select IRQ_DOMAIN_HIERARCHY
> help
> MSM Power Manager driver to manage and configure wakeup
> --
> 2.17.1
>

Subject: [irqchip: irq/irqchip-fixes] irq/qcom-mpm: Fix build error without MAILBOX

The following commit has been merged into the irq/irqchip-fixes branch of irqchip:

Commit-ID: fa4dcc880390fbedf4118e9f88a6b13363e0a7a1
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/fa4dcc880390fbedf4118e9f88a6b13363e0a7a1
Author: YueHaibing <[email protected]>
AuthorDate: Thu, 17 Mar 2022 21:19:56 +08:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Tue, 05 Apr 2022 16:33:13 +01:00

irq/qcom-mpm: Fix build error without MAILBOX

If MAILBOX is n, building fails:

drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'

Make QCOM_MPM depends on MAILBOX to fix this.

Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
Signed-off-by: YueHaibing <[email protected]>
Acked-by: Shawn Guo <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 680d2fc..15edb9a 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -433,6 +433,7 @@ config QCOM_PDC
config QCOM_MPM
tristate "QCOM MPM"
depends on ARCH_QCOM
+ depends on MAILBOX
select IRQ_DOMAIN_HIERARCHY
help
MSM Power Manager driver to manage and configure wakeup