2022-03-25 18:05:00

by Stephen Kitt

[permalink] [raw]
Subject: [PATCH] docs: i2c: reference simple probes

Instead of documenting old-style probes, reference "simple probes" and
document the i2c_match_id function. This might help reduce the use of
two-argument probes in new code.

Signed-off-by: Stephen Kitt <[email protected]>
---
Documentation/i2c/writing-clients.rst | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/Documentation/i2c/writing-clients.rst b/Documentation/i2c/writing-clients.rst
index 978cc8210bf3..e3b126cf4a3b 100644
--- a/Documentation/i2c/writing-clients.rst
+++ b/Documentation/i2c/writing-clients.rst
@@ -46,7 +46,7 @@ driver model device node, and its I2C address.
},

.id_table = foo_idtable,
- .probe = foo_probe,
+ .probe_new = foo_probe,
.remove = foo_remove,
/* if device autodetection is needed: */
.class = I2C_CLASS_SOMETHING,
@@ -155,8 +155,7 @@ those devices, and a remove() method to unbind.

::

- static int foo_probe(struct i2c_client *client,
- const struct i2c_device_id *id);
+ static int foo_probe(struct i2c_client *client);
static int foo_remove(struct i2c_client *client);

Remember that the i2c_driver does not create those client handles. The
@@ -165,8 +164,12 @@ handle may be used during foo_probe(). If foo_probe() reports success
foo_remove() returns. That binding model is used by most Linux drivers.

The probe function is called when an entry in the id_table name field
-matches the device's name. It is passed the entry that was matched so
-the driver knows which one in the table matched.
+matches the device's name. If the probe function needs that entry, it
+can retrieve it using
+
+::
+
+ const struct i2c_device_id *id = i2c_match_id(foo_idtable, client);


Device Creation
--
2.27.0


2022-05-04 23:15:11

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] docs: i2c: reference simple probes

On Fri, Mar 25, 2022 at 05:19:10PM +0100, Stephen Kitt wrote:
> Instead of documenting old-style probes, reference "simple probes" and
> document the i2c_match_id function. This might help reduce the use of
> two-argument probes in new code.
>
> Signed-off-by: Stephen Kitt <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (331.00 B)
signature.asc (849.00 B)
Download all attachments