2022-04-12 20:26:12

by kernel test robot

[permalink] [raw]
Subject: [linux-stable-rc:queue/5.17 638/1505] drivers/net/dsa/realtek/realtek-smi-core.c:494:34: warning: unused variable 'realtek_smi_of_match'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.17
head: 22fa848c25c536c9ec7b151d56caa65b3e5b8b68
commit: b0cbd13db467ef03b28297d3effb6b726c0dcba8 [638/1505] net: dsa: realtek-smi: move to subdirectory
config: x86_64-randconfig-r033-20220411 (https://download.01.org/0day-ci/archive/20220412/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b0cbd13db467ef03b28297d3effb6b726c0dcba8
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc queue/5.17
git checkout b0cbd13db467ef03b28297d3effb6b726c0dcba8
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/realtek/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/realtek/realtek-smi-core.c:494:34: warning: unused variable 'realtek_smi_of_match' [-Wunused-const-variable]
static const struct of_device_id realtek_smi_of_match[] = {
^
1 warning generated.


vim +/realtek_smi_of_match +494 drivers/net/dsa/realtek/realtek-smi-core.c

0650bf52b31ff3 drivers/net/dsa/realtek-smi-core.c Vladimir Oltean 2021-09-17 493
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 @494 static const struct of_device_id realtek_smi_of_match[] = {
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 495 {
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 496 .compatible = "realtek,rtl8366rb",
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 497 .data = &rtl8366rb_variant,
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 498 },
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 499 {
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 500 /* FIXME: add support for RTL8366S and more */
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 501 .compatible = "realtek,rtl8366s",
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 502 .data = NULL,
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 503 },
4af2950c50c863 drivers/net/dsa/realtek-smi-core.c Alvin Šipraga 2021-10-18 504 {
4af2950c50c863 drivers/net/dsa/realtek-smi-core.c Alvin Šipraga 2021-10-18 505 .compatible = "realtek,rtl8365mb",
4af2950c50c863 drivers/net/dsa/realtek-smi-core.c Alvin Šipraga 2021-10-18 506 .data = &rtl8365mb_variant,
4af2950c50c863 drivers/net/dsa/realtek-smi-core.c Alvin Šipraga 2021-10-18 507 },
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 508 { /* sentinel */ },
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 509 };
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 510 MODULE_DEVICE_TABLE(of, realtek_smi_of_match);
d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 511

:::::: The code at line 494 was first introduced by commit
:::::: d8652956cf37c5caa8c19e0b99ce5ca235c6d5de net: dsa: realtek-smi: Add Realtek SMI driver

:::::: TO: Linus Walleij <[email protected]>
:::::: CC: David S. Miller <[email protected]>

--
0-DAY CI Kernel Test Service
https://01.org/lkp


2022-04-12 23:12:36

by Alvin Šipraga

[permalink] [raw]
Subject: Re: [linux-stable-rc:queue/5.17 638/1505] drivers/net/dsa/realtek/realtek-smi-core.c:494:34: warning: unused variable 'realtek_smi_of_match'

Hello test robot,

On Tue, Apr 12, 2022 at 03:36:24PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.17
> head: 22fa848c25c536c9ec7b151d56caa65b3e5b8b68
> commit: b0cbd13db467ef03b28297d3effb6b726c0dcba8 [638/1505] net: dsa: realtek-smi: move to subdirectory
> config: x86_64-randconfig-r033-20220411 (https://download.01.org/0day-ci/archive/20220412/[email protected]/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b0cbd13db467ef03b28297d3effb6b726c0dcba8
> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> git fetch --no-tags linux-stable-rc queue/5.17
> git checkout b0cbd13db467ef03b28297d3effb6b726c0dcba8
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/realtek/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/net/dsa/realtek/realtek-smi-core.c:494:34: warning: unused variable 'realtek_smi_of_match' [-Wunused-const-variable]
> static const struct of_device_id realtek_smi_of_match[] = {
> ^
> 1 warning generated.

This should be fixed by including the commit:

109d899452ba1 ("net: dsa: realtek: make interface drivers depend on OF").

in the stable tree.

Kind regards,
Alvin

>
>
> vim +/realtek_smi_of_match +494 drivers/net/dsa/realtek/realtek-smi-core.c
>
> 0650bf52b31ff3 drivers/net/dsa/realtek-smi-core.c Vladimir Oltean 2021-09-17 493
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 @494 static const struct of_device_id realtek_smi_of_match[] = {
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 495 {
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 496 .compatible = "realtek,rtl8366rb",
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 497 .data = &rtl8366rb_variant,
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 498 },
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 499 {
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 500 /* FIXME: add support for RTL8366S and more */
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 501 .compatible = "realtek,rtl8366s",
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 502 .data = NULL,
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 503 },
> 4af2950c50c863 drivers/net/dsa/realtek-smi-core.c Alvin Šipraga 2021-10-18 504 {
> 4af2950c50c863 drivers/net/dsa/realtek-smi-core.c Alvin Šipraga 2021-10-18 505 .compatible = "realtek,rtl8365mb",
> 4af2950c50c863 drivers/net/dsa/realtek-smi-core.c Alvin Šipraga 2021-10-18 506 .data = &rtl8365mb_variant,
> 4af2950c50c863 drivers/net/dsa/realtek-smi-core.c Alvin Šipraga 2021-10-18 507 },
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 508 { /* sentinel */ },
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 509 };
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 510 MODULE_DEVICE_TABLE(of, realtek_smi_of_match);
> d8652956cf37c5 drivers/net/dsa/realtek-smi.c Linus Walleij 2018-07-14 511
>
> :::::: The code at line 494 was first introduced by commit
> :::::: d8652956cf37c5caa8c19e0b99ce5ca235c6d5de net: dsa: realtek-smi: Add Realtek SMI driver
>
> :::::: TO: Linus Walleij <[email protected]>
> :::::: CC: David S. Miller <[email protected]>
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp

2022-04-15 12:02:51

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [linux-stable-rc:queue/5.17 638/1505] drivers/net/dsa/realtek/realtek-smi-core.c:494:34: warning: unused variable 'realtek_smi_of_match'

On Tue, Apr 12, 2022 at 10:32:31AM +0000, Alvin Šipraga wrote:
> Hello test robot,
>
> On Tue, Apr 12, 2022 at 03:36:24PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.17
> > head: 22fa848c25c536c9ec7b151d56caa65b3e5b8b68
> > commit: b0cbd13db467ef03b28297d3effb6b726c0dcba8 [638/1505] net: dsa: realtek-smi: move to subdirectory
> > config: x86_64-randconfig-r033-20220411 (https://download.01.org/0day-ci/archive/20220412/[email protected]/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b0cbd13db467ef03b28297d3effb6b726c0dcba8
> > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > git fetch --no-tags linux-stable-rc queue/5.17
> > git checkout b0cbd13db467ef03b28297d3effb6b726c0dcba8
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/realtek/
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/net/dsa/realtek/realtek-smi-core.c:494:34: warning: unused variable 'realtek_smi_of_match' [-Wunused-const-variable]
> > static const struct of_device_id realtek_smi_of_match[] = {
> > ^
> > 1 warning generated.
>
> This should be fixed by including the commit:
>
> 109d899452ba1 ("net: dsa: realtek: make interface drivers depend on OF").
>
> in the stable tree.

Great, can you provide a working backport so it can be included?

thanks,

greg k-h

2022-04-15 19:09:17

by Alvin Šipraga

[permalink] [raw]
Subject: Re: [linux-stable-rc:queue/5.17 638/1505] drivers/net/dsa/realtek/realtek-smi-core.c:494:34: warning: unused variable 'realtek_smi_of_match'

On Thu, Apr 14, 2022 at 12:51:03PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 12, 2022 at 10:32:31AM +0000, Alvin Šipraga wrote:
> > Hello test robot,
> >
> > On Tue, Apr 12, 2022 at 03:36:24PM +0800, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.17
> > > head: 22fa848c25c536c9ec7b151d56caa65b3e5b8b68
> > > commit: b0cbd13db467ef03b28297d3effb6b726c0dcba8 [638/1505] net: dsa: realtek-smi: move to subdirectory
> > > config: x86_64-randconfig-r033-20220411 (https://download.01.org/0day-ci/archive/20220412/[email protected]/config)
> > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b0cbd13db467ef03b28297d3effb6b726c0dcba8
> > > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > git fetch --no-tags linux-stable-rc queue/5.17
> > > git checkout b0cbd13db467ef03b28297d3effb6b726c0dcba8
> > > # save the config file to linux build tree
> > > mkdir build_dir
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/realtek/
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <[email protected]>
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/net/dsa/realtek/realtek-smi-core.c:494:34: warning: unused variable 'realtek_smi_of_match' [-Wunused-const-variable]
> > > static const struct of_device_id realtek_smi_of_match[] = {
> > > ^
> > > 1 warning generated.
> >
> > This should be fixed by including the commit:
> >
> > 109d899452ba1 ("net: dsa: realtek: make interface drivers depend on OF").
> >
> > in the stable tree.
>
> Great, can you provide a working backport so it can be included?

Sure, it was one of 3 backports I sent that you have just queued up:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/commit/?id=463ea09d17cb51165a46e75e1d531a9cac04cbbe

Should be all good now.

Kind regards,
Alvin