LinuxLists.cc - [krzk-github:n/qcom-ufs-opp-v2 14/16] drivers/opp/core.c:1215 dev_pm_opp_set_rate() error: uninitialized symbol 'ret'.

2022-04-16 00:14:50

Subject: [krzk-github:n/qcom-ufs-opp-v2 14/16] drivers/opp/core.c:1215 dev_pm_opp_set_rate() error: uninitialized symbol 'ret'.

tree: htt
com/krzk/linux">https://github.com/krzk/linux n/qcom-ufs-opp-v2
3a9bcfd2e1f54eb
204fe7496e2ee5f [14/16] PM: opp: allow control of multiple clocks
href="https://download.01.org/0day-ci/archive/20220415/202204150900.qnJMf3Gu-lkp@intel.com/config)">https://download.01.org/0day-ci/archive/20220415/[email protected]/config)
11.2.0-19) 11.2.0
add following tag as appropriate
robot <[email protected]>
<[email protected]>
dev_pm_opp_set_rate() error: uninitialized symbol 'ret'.
dev_pm_opp_set_rate() warn: passing a valid pointer to 'PTR_ERR'
_opp_set_availability() warn: passing a valid pointer to 'PTR_ERR'
dev_pm_opp_adjust_voltage() warn: passing a valid pointer to 'PTR_ERR'
/> Viresh Kumar 2021-01-21 1155 int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
Viresh Kumar 2021-01-21 1156 {
Viresh Kumar 2021-01-21 1157 struct opp_table *opp_table;
Viresh Kumar 2021-01-21 1158 unsigned long freq = 0, temp_freq;
Viresh Kumar 2021-01-21 1159 struct dev_pm_opp *opp = NULL;
Viresh Kumar 2021-01-21 1160 int ret;
Viresh Kumar 2021-01-21 1161
Viresh Kumar 2021-01-21 1162 opp_table = _find_opp_table(dev);
Viresh Kumar 2021-01-21 1163 if (IS_ERR(opp_table)) {
Viresh Kumar 2021-01-21 1164 dev_err(dev, "%s: device's opp table doesn't exist\n", __func__);
Viresh Kumar 2021-01-21 1165 return PTR_ERR(opp_table);
Viresh Kumar 2021-01-21 1166 }
Viresh Kumar 2021-01-21 1167
Viresh Kumar 2021-01-21 1168 if (target_freq) {
Viresh Kumar 2021-01-21 1169 /*
Viresh Kumar 2021-01-21 1170 * For IO devices which require an OPP on some platforms/SoCs
Viresh Kumar 2021-01-21 1171 * while just needing to scale the clock on some others
Viresh Kumar 2021-01-21 1172 * we look for empty OPP tables with just a clock handle and
Viresh Kumar 2021-01-21 1173 * scale only the clk. This makes dev_pm_opp_set_rate()
Viresh Kumar 2021-01-21 1174 * equivalent to a clk_set_rate()
Viresh Kumar 2021-01-21 1175 */
Viresh Kumar 2021-01-21 1176 if (!_get_opp_count(opp_table)) {
Krzysztof Kozlowski 2022-04-05 1177 if (opp_table->clks)
Krzysztof Kozlowski 2022-04-05 1178 ret = _generic_set_opp_clk_only(dev,
Krzysztof Kozlowski 2022-04-05 1179 opp_table->clks[0],
Krzysztof Kozlowski 2022-04-05 1180 target_freq);
on else path.
Viresh Kumar 2021-01-21 1181 goto put_opp_table;
Viresh Kumar 2021-01-21 1182 }
Viresh Kumar 2021-01-21 1183
Krzysztof Kozlowski 2022-04-05 1184 if (opp_table->clks)
Krzysztof Kozlowski 2022-04-05 1185 freq = clk_round_rate(opp_table->clks[0], target_freq);
Viresh Kumar 2021-01-21 1186 if ((long)freq <= 0)
Viresh Kumar 2021-01-21 1187 freq = target_freq;
Viresh Kumar 2021-01-21 1188
Viresh Kumar 2021-01-21 1189 /*
Viresh Kumar 2021-01-21 1190 * The clock driver may support finer resolution of the
Viresh Kumar 2021-01-21 1191 * frequencies than the OPP table, don't update the frequency we
Viresh Kumar 2021-01-21 1192 * pass to clk_set_rate() here.
Viresh Kumar 2021-01-21 1193 */
Viresh Kumar 2021-01-21 1194 temp_freq = freq;
Viresh Kumar 2021-01-21 1195 opp = _find_freq_ceil(opp_table, &temp_freq);
Viresh Kumar 2021-01-21 1196 if (IS_ERR(opp)) {
Viresh Kumar 2021-01-21 1197 ret = PTR_ERR(opp);
Viresh Kumar 2021-01-21 1198 dev_err(dev, "%s: failed to find OPP for freq %lu (%d)\n",
Viresh Kumar 2021-01-21 1199 __func__, freq, ret);
Viresh Kumar 2021-01-21 1200 goto put_opp_table;
Viresh Kumar 2021-01-21 1201 }
Krzysztof Kozlowski 2022-04-05 1202 /*
Krzysztof Kozlowski 2022-04-05 1203 * opp->rates are used for scaling clocks, so be sure accurate
Krzysztof Kozlowski 2022-04-05 1204 * 'freq' is used, instead what was defined via e.g. Devicetree.
Krzysztof Kozlowski 2022-04-05 1205 */
Krzysztof Kozlowski 2022-04-05 1206 opp->rates[0] = freq;
Viresh Kumar 2021-01-21 1207 }
Viresh Kumar 2021-01-21 1208
Viresh Kumar 2021-01-21 1209 ret = _set_opp(dev, opp_table, opp, freq);
Viresh Kumar 2021-01-21 1210
Viresh Kumar 2021-01-21 1211 if (target_freq)
Viresh Kumar 2017-01-23 1212 dev_pm_opp_put(opp);
Viresh Kumar 2017-01-23 1213 put_opp_table:
Viresh Kumar 2017-01-23 1214 dev_pm_opp_put_opp_table(opp_table);
Viresh Kumar 2017-01-23 @1215 return ret;
Viresh Kumar 2016-02-09 1216 }
ps://01.org/lkp

2022-04-16 00:17:45

by Dan Carpenter

[permalink] [raw]

Subject: Re: [krzk-github:n/qcom-ufs-opp-v2 14/16] drivers/opp/core.c:1215 dev_pm_opp_set_rate() error: uninitialized symbol 'ret'.

On Fri, Apr 15, 2022 at 09:45:47AM +0300, Dan Carpenter wrote:
> tree: https://github.com/krzk/linux n/qcom-ufs-opp-v2
> head: bf7d30c9329c87f06dff42b303a9bcfd2e1f54eb
> commit: be46c855d54f763bfb95424e5204fe7496e2ee5f [14/16] PM: opp: allow control of multiple clocks
> config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220415/[email protected]/config)
> compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
>
> New smatch warnings:
> drivers/opp/core.c:1215 dev_pm_opp_set_rate() error: uninitialized symbol 'ret'.
>

This one is the warning I meant to include.

> Old smatch warnings:
> drivers/opp/core.c:1197 dev_pm_opp_set_rate() warn: passing a valid pointer to 'PTR_ERR'
> drivers/opp/core.c:2813 _opp_set_availability() warn: passing a valid pointer to 'PTR_ERR'
> drivers/opp/core.c:2884 dev_pm_opp_adjust_voltage() warn: passing a valid pointer to 'PTR_ERR'

Sorry, these are false positives. It comes from Smatch thinking
pointers are signed on certain arches. I've been too lazy to set up a
cross compile system to debug the issue, but I really need to do that. :/

regards,
dan carpenter