Subject: Re: [PATCH v6, 5/5] dt-bindings: pwm: Add interrupts property for MediaTek MT8192

Il 18/04/22 14:20, [email protected] ha scritto:
> From: Xinlei Lee <[email protected]>
>
> Add interrupts property of pwm for MediaTek MT8192 SoC.
>
> Signed-off-by: Xinlei Lee <[email protected]>

Hello Xinlei,
the pwm-mtk-disp.c driver does not support interrupts.

Please add interrupts support to the driver first, and only then
add that in the dt-bindings.

Regards,
Angelo


2022-04-22 19:29:55

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH v6, 5/5] dt-bindings: pwm: Add interrupts property for MediaTek MT8192

Hello,

On Thu, Apr 21, 2022 at 12:17:00PM +0200, AngeloGioacchino Del Regno wrote:
> Il 18/04/22 14:20, [email protected] ha scritto:
> > From: Xinlei Lee <[email protected]>
> >
> > Add interrupts property of pwm for MediaTek MT8192 SoC.
> >
> > Signed-off-by: Xinlei Lee <[email protected]>
>
> Hello Xinlei,
> the pwm-mtk-disp.c driver does not support interrupts.
>
> Please add interrupts support to the driver first, and only then
> add that in the dt-bindings.

in my understanding the linux driver state and the binding documentation
are somewhat independent. Here I'd say adding the irq information to dt
without the driver supporting it is fine.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachments:
(No filename) (878.00 B)
 signature.asc (499.00 B)
 Download all attachments

2022-04-22 21:10:34

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v6, 5/5] dt-bindings: pwm: Add interrupts property for MediaTek MT8192

On Thu, Apr 21, 2022 at 03:48:08PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Apr 21, 2022 at 12:17:00PM +0200, AngeloGioacchino Del Regno wrote:
> > Il 18/04/22 14:20, [email protected] ha scritto:
> > > From: Xinlei Lee <[email protected]>
> > >
> > > Add interrupts property of pwm for MediaTek MT8192 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <[email protected]>
> >
> > Hello Xinlei,
> > the pwm-mtk-disp.c driver does not support interrupts.
> >
> > Please add interrupts support to the driver first, and only then
> > add that in the dt-bindings.
>
> in my understanding the linux driver state and the binding documentation
> are somewhat independent. Here I'd say adding the irq information to dt
> without the driver supporting it is fine.

Agreed. I've applied this along with the rest. It doesn't have Rob's or
Krzysztof's stamp of approval, but it's a trivial change and looks fine
to me.

Thierry

Attachments:
(No filename) (971.00 B)
 signature.asc (849.00 B)
 Download all attachments