2022-04-22 10:55:32

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH] staging: r8188eu: use in-kernel ieee channel

On Thu, Apr 21, 2022 at 09:58:12AM +0800, Solomon Tan wrote:
> The rtw_ieee80211_channel structure just duplicates the in-kernel
> ieee80211_channel structure

When you say that they are duplicates, I expected them to be the same
but they're not at all. ieee80211_channel has a bunch more struct
members.

I don't really have a problem with the change necessarily but the commit
message should not have mislead me.

regards,
dan carpenter


2022-04-22 19:57:07

by Solomon Tan

[permalink] [raw]
Subject: Re: [PATCH] staging: r8188eu: use in-kernel ieee channel

On Thu, Apr 21, 2022 at 08:00:10PM +0300, Dan Carpenter wrote:
> On Thu, Apr 21, 2022 at 09:58:12AM +0800, Solomon Tan wrote:
> > The rtw_ieee80211_channel structure just duplicates the in-kernel
> > ieee80211_channel structure
>
> When you say that they are duplicates, I expected them to be the same
> but they're not at all. ieee80211_channel has a bunch more struct
> members.
>
> I don't really have a problem with the change necessarily but the commit
> message should not have mislead me.

Sorry about that. I will amend the commit message and send it as v2.
Thank you for the review.

>
> regards,
> dan carpenter
>

Cheers,
Solomon