2022-04-22 18:24:28

by Fabio M. De Francesco

[permalink] [raw]
Subject: [PATCH 2/4] Documentation/vm: Include kdocs from highmem*.h into highmem.rst

kernel-docs that are in include/linux/highmem.h and in
include/linux/highmem-internal.h should be included in highmem.rst.

Use kdocs directives to include the above-mentioned comments into
highmem.rst.

Cc: Jonathan Corbet <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ira Weiny <[email protected]>
Cc: Matthew Wilcox <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Signed-off-by: Fabio M. De Francesco <[email protected]>
---
Documentation/vm/highmem.rst | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/vm/highmem.rst b/Documentation/vm/highmem.rst
index 0f69a9fec34d..ccff08a8211d 100644
--- a/Documentation/vm/highmem.rst
+++ b/Documentation/vm/highmem.rst
@@ -145,3 +145,10 @@ The general recommendation is that you don't use more than 8GiB on a 32-bit
machine - although more might work for you and your workload, you're pretty
much on your own - don't expect kernel developers to really care much if things
come apart.
+
+
+Functions
+=========
+
+.. kernel-doc:: include/linux/highmem.h
+.. kernel-doc:: include/linux/highmem-internal.h
--
2.34.1


2022-04-22 19:31:09

by Mike Rapoport

[permalink] [raw]
Subject: Re: [PATCH 2/4] Documentation/vm: Include kdocs from highmem*.h into highmem.rst

On Thu, Apr 21, 2022 at 08:01:58PM +0200, Fabio M. De Francesco wrote:
> kernel-docs that are in include/linux/highmem.h and in
> include/linux/highmem-internal.h should be included in highmem.rst.
>
> Use kdocs directives to include the above-mentioned comments into
> highmem.rst.
>
> Cc: Jonathan Corbet <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Ira Weiny <[email protected]>
> Cc: Matthew Wilcox <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Signed-off-by: Fabio M. De Francesco <[email protected]>

Acked-by: Mike Rapoport <[email protected]>

> ---
> Documentation/vm/highmem.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/vm/highmem.rst b/Documentation/vm/highmem.rst
> index 0f69a9fec34d..ccff08a8211d 100644
> --- a/Documentation/vm/highmem.rst
> +++ b/Documentation/vm/highmem.rst
> @@ -145,3 +145,10 @@ The general recommendation is that you don't use more than 8GiB on a 32-bit
> machine - although more might work for you and your workload, you're pretty
> much on your own - don't expect kernel developers to really care much if things
> come apart.
> +
> +
> +Functions
> +=========
> +
> +.. kernel-doc:: include/linux/highmem.h
> +.. kernel-doc:: include/linux/highmem-internal.h
> --
> 2.34.1
>
>

--
Sincerely yours,
Mike.

2022-04-22 23:02:21

by Ira Weiny

[permalink] [raw]
Subject: Re: [PATCH 2/4] Documentation/vm: Include kdocs from highmem*.h into highmem.rst

On Thu, Apr 21, 2022 at 08:01:58PM +0200, Fabio M. De Francesco wrote:
> kernel-docs that are in include/linux/highmem.h and in
> include/linux/highmem-internal.h should be included in highmem.rst.
>
> Use kdocs directives to include the above-mentioned comments into
> highmem.rst.
>
> Cc: Jonathan Corbet <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Ira Weiny <[email protected]>
> Cc: Matthew Wilcox <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Signed-off-by: Fabio M. De Francesco <[email protected]>

Reviewed-by: Ira Weiny <[email protected]>

> ---
> Documentation/vm/highmem.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/vm/highmem.rst b/Documentation/vm/highmem.rst
> index 0f69a9fec34d..ccff08a8211d 100644
> --- a/Documentation/vm/highmem.rst
> +++ b/Documentation/vm/highmem.rst
> @@ -145,3 +145,10 @@ The general recommendation is that you don't use more than 8GiB on a 32-bit
> machine - although more might work for you and your workload, you're pretty
> much on your own - don't expect kernel developers to really care much if things
> come apart.
> +
> +
> +Functions
> +=========
> +
> +.. kernel-doc:: include/linux/highmem.h
> +.. kernel-doc:: include/linux/highmem-internal.h
> --
> 2.34.1
>