2022-04-22 20:30:18

by Jiapeng Chong

Subject: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting

Eliminate the follow smatch warning:

drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
rockchip_usb2phy_probe() warn: inconsistent indenting.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index e377b958d9b6..6711659f727c 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -1200,8 +1200,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)

else {
rphy->grf = syscon_node_to_regmap(dev->parent->of_node);
- if (IS_ERR(rphy->grf))
- return PTR_ERR(rphy->grf);
+ if (IS_ERR(rphy->grf))
+ return PTR_ERR(rphy->grf);
}

if (of_device_is_compatible(np, "rockchip,rv1108-usb2phy")) {
--
2.20.1.7.g153144c

2022-05-02 23:42:07

by Vinod Koul

Subject: Re: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting

On 22-04-22, 04:30, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
> rockchip_usb2phy_probe() warn: inconsistent indenting.

Applied, thanks

--
~Vinod

2022-05-03 00:29:28

by Heiko Stuebner

Subject: Re: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting

Am Donnerstag, 21. April 2022, 22:30:38 CEST schrieb Jiapeng Chong:
> Eliminate the follow smatch warning:
>
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
> rockchip_usb2phy_probe() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Heiko Stuebner <[email protected]>

> ---
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index e377b958d9b6..6711659f727c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -1200,8 +1200,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
>
> else {
> rphy->grf = syscon_node_to_regmap(dev->parent->of_node);
> - if (IS_ERR(rphy->grf))
> - return PTR_ERR(rphy->grf);
> + if (IS_ERR(rphy->grf))
> + return PTR_ERR(rphy->grf);
> }
>
> if (of_device_is_compatible(np, "rockchip,rv1108-usb2phy")) {
>