2022-04-24 16:06:00

by CGEL

Subject: [PATCH] EDAC,wq: remove unneeded flush_workqueue

From: ran jianping <[email protected]>

All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ran jianping <[email protected]>
---
drivers/edac/wq.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
index d021d287eaec..ad3f516627c5 100644
--- a/drivers/edac/wq.c
+++ b/drivers/edac/wq.c
@@ -37,7 +37,6 @@ int edac_workqueue_setup(void)

void edac_workqueue_teardown(void)
{
- flush_workqueue(wq);
destroy_workqueue(wq);
wq = NULL;
}
--
2.25.1

2022-08-25 09:03:12

by Borislav Petkov

Subject: Re: [PATCH] EDAC,wq: remove unneeded flush_workqueue

On Sun, Apr 24, 2022 at 06:21:26AM +0000, [email protected] wrote:
> From: ran jianping <[email protected]>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ran jianping <[email protected]>
> ---
> drivers/edac/wq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
> index d021d287eaec..ad3f516627c5 100644
> --- a/drivers/edac/wq.c
> +++ b/drivers/edac/wq.c
> @@ -37,7 +37,6 @@ int edac_workqueue_setup(void)
>
> void edac_workqueue_teardown(void)
> {
> - flush_workqueue(wq);
> destroy_workqueue(wq);
> wq = NULL;
> }
> --

Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette