From: Minghao Chi <[email protected]>
Since there's a return immediately after the 'break', there's no need for
this extra 'return'.
Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/clocksource/timer-msc313e.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/clocksource/timer-msc313e.c b/drivers/clocksource/timer-msc313e.c
index 54c54ca7c786..fedcbcafd320 100644
--- a/drivers/clocksource/timer-msc313e.c
+++ b/drivers/clocksource/timer-msc313e.c
@@ -233,14 +233,10 @@ static int __init msc313e_timer_init(struct device_node *np)
switch (num_called) {
case 0:
ret = msc313e_clksrc_init(np);
- if (ret)
- return ret;
break;
default:
ret = msc313e_clkevt_init(np);
- if (ret)
- return ret;
break;
}
--
2.25.1
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/timers/core]
[also build test WARNING on v5.18-rc4 next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/clocksource-drivers-remove-unnecessary-return-in-switch-statement/20220425-170540
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ce8abf340e40e1126bfcb9e7679b3d6b524ae3e0
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220426/[email protected]/config)
compiler: sh4-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f185e49aea517bee5dfb706df47fa5f70bfac370
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review cgel-zte-gmail-com/clocksource-drivers-remove-unnecessary-return-in-switch-statement/20220425-170540
git checkout f185e49aea517bee5dfb706df47fa5f70bfac370
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/clocksource/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
drivers/clocksource/timer-msc313e.c: In function 'msc313e_timer_init':
>> drivers/clocksource/timer-msc313e.c:230:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
230 | int ret = 0;
| ^~~
vim +/ret +230 drivers/clocksource/timer-msc313e.c
5fc1f93f69989e Romain Perier 2021-12-17 227
5fc1f93f69989e Romain Perier 2021-12-17 228 static int __init msc313e_timer_init(struct device_node *np)
5fc1f93f69989e Romain Perier 2021-12-17 229 {
5fc1f93f69989e Romain Perier 2021-12-17 @230 int ret = 0;
5fc1f93f69989e Romain Perier 2021-12-17 231 static int num_called;
5fc1f93f69989e Romain Perier 2021-12-17 232
5fc1f93f69989e Romain Perier 2021-12-17 233 switch (num_called) {
5fc1f93f69989e Romain Perier 2021-12-17 234 case 0:
5fc1f93f69989e Romain Perier 2021-12-17 235 ret = msc313e_clksrc_init(np);
5fc1f93f69989e Romain Perier 2021-12-17 236 break;
5fc1f93f69989e Romain Perier 2021-12-17 237
5fc1f93f69989e Romain Perier 2021-12-17 238 default:
5fc1f93f69989e Romain Perier 2021-12-17 239 ret = msc313e_clkevt_init(np);
5fc1f93f69989e Romain Perier 2021-12-17 240 break;
5fc1f93f69989e Romain Perier 2021-12-17 241 }
5fc1f93f69989e Romain Perier 2021-12-17 242
5fc1f93f69989e Romain Perier 2021-12-17 243 num_called++;
5fc1f93f69989e Romain Perier 2021-12-17 244
5fc1f93f69989e Romain Perier 2021-12-17 245 return 0;
5fc1f93f69989e Romain Perier 2021-12-17 246 }
5fc1f93f69989e Romain Perier 2021-12-17 247
--
0-DAY CI Kernel Test Service
https://01.org/lkp