The pointer tlbk is not used, it is redundant and can be removed.
Cleans up cppcheck warning:
linux/fs/jfs/jfs_xtree.c:2551:17: style: Unused variable: tblk [unusedVariable]
Signed-off-by: Colin Ian King <[email protected]>
---
fs/jfs/jfs_xtree.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c
index 3148e9b35f3b..d29979d0a6aa 100644
--- a/fs/jfs/jfs_xtree.c
+++ b/fs/jfs/jfs_xtree.c
@@ -2548,7 +2548,6 @@ xtRelocate(tid_t tid, struct inode * ip, xad_t * oxad, /* old XAD */
int xtype)
{ /* extent type: XTPAGE or DATAEXT */
int rc = 0;
- struct tblock *tblk;
struct tlock *tlck;
struct xtlock *xtlck;
struct metapage *mp, *pmp, *lmp, *rmp; /* meta-page buffer */
--
2.35.1
On Sun, Apr 24, 2022 at 05:13:30PM +0100, Colin Ian King wrote:
> The pointer tlbk is not used, it is redundant and can be removed.
> Cleans up cppcheck warning:
>
> linux/fs/jfs/jfs_xtree.c:2551:17: style: Unused variable: tblk [unusedVariable]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/jfs/jfs_xtree.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c
> index 3148e9b35f3b..d29979d0a6aa 100644
> --- a/fs/jfs/jfs_xtree.c
> +++ b/fs/jfs/jfs_xtree.c
> @@ -2548,7 +2548,6 @@ xtRelocate(tid_t tid, struct inode * ip, xad_t * oxad, /* old XAD */
> int xtype)
> { /* extent type: XTPAGE or DATAEXT */
> int rc = 0;
> - struct tblock *tblk;
This would have caused a build error if it weren't ifdeffed out.
#ifdef _STILL_TO_PORT
JFS is an IBM filesystem from OS/2. Apparently, this stuff never got
ported? Probably we could just delete the dead code.
regards,
dan carpenter
On 4/25/22 9:48AM, Dan Carpenter wrote:
> On Sun, Apr 24, 2022 at 05:13:30PM +0100, Colin Ian King wrote:
>> The pointer tlbk is not used, it is redundant and can be removed.
>> Cleans up cppcheck warning:
>>
>> linux/fs/jfs/jfs_xtree.c:2551:17: style: Unused variable: tblk [unusedVariable]
>>
>> Signed-off-by: Colin Ian King <[email protected]>
>> ---
>> fs/jfs/jfs_xtree.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c
>> index 3148e9b35f3b..d29979d0a6aa 100644
>> --- a/fs/jfs/jfs_xtree.c
>> +++ b/fs/jfs/jfs_xtree.c
>> @@ -2548,7 +2548,6 @@ xtRelocate(tid_t tid, struct inode * ip, xad_t * oxad, /* old XAD */
>> int xtype)
>> { /* extent type: XTPAGE or DATAEXT */
>> int rc = 0;
>> - struct tblock *tblk;
>
> This would have caused a build error if it weren't ifdeffed out.
>
> #ifdef _STILL_TO_PORT
>
> JFS is an IBM filesystem from OS/2. Apparently, this stuff never got
> ported? Probably we could just delete the dead code.
Yeah. Once, long ago, I had dreams of enhancing JFS with shiny new
function like defragmentation. I think it's safe to say that isn't going
to happen.
Shaggy
>
> regards,
> dan carpenter
>