2022-04-26 14:33:41

by David Heidelberg

Subject: [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450

Fill missing compatible already used in SM8450 DTS.

Signed-off-by: David Heidelberg <[email protected]>
---
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
index 866efb278813..c57dd423e98c 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
@@ -27,6 +27,7 @@ properties:
- qcom,sm6350-ipcc
- qcom,sm8250-ipcc
- qcom,sm8350-ipcc
+ - qcom,sm8450-ipcc
- qcom,sc7280-ipcc
- const: qcom,ipcc

--
2.35.1

2022-04-26 14:39:03

by David Heidelberg

Subject: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

These missing required properties are needed for
smp2p binding reference checks.

Also includes cosmetic change to the example formatting.

Reviewed-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: David Heidelberg <[email protected]>
---
v3:
- add Krzysztof R-b
---
.../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
index c57dd423e98c..50f9aa72c670 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
@@ -76,9 +76,14 @@ examples:

smp2p-modem {
compatible = "qcom,smp2p";
- interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
- IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
- mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
+ qcom,smem = <443>, <429>;
+ interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_SMP2P
+ IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_SMP2P>;

+ qcom,local-pid = <0>;
+ qcom,remote-pid = <2>;
/* Other SMP2P fields */
};
--
2.35.1

2022-04-27 10:58:15

by Dmitry Baryshkov

Subject: Re: [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450

On Tue, 26 Apr 2022 at 13:34, David Heidelberg <[email protected]> wrote:
>
> Fill missing compatible already used in SM8450 DTS.
>
> Signed-off-by: David Heidelberg <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>

> ---
> Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index 866efb278813..c57dd423e98c 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -27,6 +27,7 @@ properties:
> - qcom,sm6350-ipcc
> - qcom,sm8250-ipcc
> - qcom,sm8350-ipcc
> + - qcom,sm8450-ipcc
> - qcom,sc7280-ipcc
> - const: qcom,ipcc
>
> --
> 2.35.1
>


--
With best wishes
Dmitry

2022-04-27 11:31:02

by Krzysztof Kozlowski

Subject: Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

On 26/04/2022 12:18, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
>
> Also includes cosmetic change to the example formatting.
>

Missing reported-by:
Reported-by: Rob Herring <[email protected]>

> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> v3:
> - add Krzysztof R-b

BTW, this patch confuses me a bit... You sent it some time after I sent
a fix:
https://lore.kernel.org/all/[email protected]/


Best regards,
Krzysztof

2022-04-27 14:55:21

by Manivannan Sadhasivam

Subject: Re: [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450

On Tue, Apr 26, 2022 at 12:18:36PM +0200, David Heidelberg wrote:
> Fill missing compatible already used in SM8450 DTS.
>
> Signed-off-by: David Heidelberg <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index 866efb278813..c57dd423e98c 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -27,6 +27,7 @@ properties:
> - qcom,sm6350-ipcc
> - qcom,sm8250-ipcc
> - qcom,sm8350-ipcc
> + - qcom,sm8450-ipcc
> - qcom,sc7280-ipcc
> - const: qcom,ipcc
>
> --
> 2.35.1
>

2022-04-27 14:56:17

by Manivannan Sadhasivam

Subject: Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

On Tue, Apr 26, 2022 at 12:18:37PM +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
>
> Also includes cosmetic change to the example formatting.
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> v3:
> - add Krzysztof R-b
> ---
> .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index c57dd423e98c..50f9aa72c670 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -76,9 +76,14 @@ examples:
>
> smp2p-modem {
> compatible = "qcom,smp2p";
> - interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
> - IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
> - mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
> + qcom,smem = <443>, <429>;
> + interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
> + IPCC_MPROC_SIGNAL_SMP2P
> + IRQ_TYPE_EDGE_RISING>;
> + mboxes = <&ipcc IPCC_CLIENT_LPASS
> + IPCC_MPROC_SIGNAL_SMP2P>;
>
> + qcom,local-pid = <0>;
> + qcom,remote-pid = <2>;
> /* Other SMP2P fields */
> };
> --
> 2.35.1
>

2022-05-03 01:28:07

by Rob Herring

Subject: Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

On Tue, Apr 26, 2022 at 12:18:37PM +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
>
> Also includes cosmetic change to the example formatting.
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> v3:
> - add Krzysztof R-b
> ---
> .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)

Applied, thanks!

2022-05-03 01:28:18

by Rob Herring

Subject: Re: [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450

On Tue, 26 Apr 2022 12:18:36 +0200, David Heidelberg wrote:
> Fill missing compatible already used in SM8450 DTS.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Applied, thanks!