2022-04-28 21:09:59

by CGEL

Subject: [PATCH] remoteproc: qcom: using pm_runtime_resume_and_get to simplify the code

From: ran jianping <[email protected]>

Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. This change is just to simplify the code, no
actual functional changes.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ran jianping <[email protected]>
---
drivers/remoteproc/qcom_q6v5_adsp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
index 2f3b9f54251e..366e1d4a839a 100644
--- a/drivers/remoteproc/qcom_q6v5_adsp.c
+++ b/drivers/remoteproc/qcom_q6v5_adsp.c
@@ -175,9 +175,8 @@ static int qcom_rproc_pds_enable(struct qcom_adsp *adsp, struct device **pds,

for (i = 0; i < pd_count; i++) {
dev_pm_genpd_set_performance_state(pds[i], INT_MAX);
- ret = pm_runtime_get_sync(pds[i]);
+ ret = pm_runtime_resume_and_get(pds[i])
if (ret < 0) {
- pm_runtime_put_noidle(pds[i]);
dev_pm_genpd_set_performance_state(pds[i], 0);
goto unroll_pd_votes;
}
--
2.25.1

2022-07-18 23:00:40

by Bjorn Andersson

Subject: Re: (subset) [PATCH] remoteproc: qcom: using pm_runtime_resume_and_get to simplify the code

On Thu, 28 Apr 2022 06:45:45 +0000, [email protected] wrote:
> From: ran jianping <[email protected]>
>
> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. This change is just to simplify the code, no
> actual functional changes.
>
>
> [...]

Applied, thanks!

[1/1] remoteproc: qcom: using pm_runtime_resume_and_get to simplify the code
commit: f2ac69165dd78fb905187736e65b25151377ed89

Best regards,
--
Bjorn Andersson <[email protected]>