Hi!
The new chip works much like the other chips supported by the driver, so
this is just adding another compatible to the list.
Chenages since v1:
- Guenter Roeck noticed elsewhere that my mail setup was botched and
that my patches were clobbered. Hopefully fixed. *blush*
- added tags from Sean Nyekjaer and Rob Herring
Cheers,
Peter
Peter Rosin (2):
dt-bindings: iio: ti-dac5571: Add ti,dac121c081
iio: dac: ti-dac5571: add support for ti,dac121c081
Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
drivers/iio/dac/Kconfig | 2 +-
drivers/iio/dac/ti-dac5571.c | 3 +++
3 files changed, 5 insertions(+), 1 deletion(-)
--
2.20.1
It fits right in as a single 12-bit DAC.
Reviewed-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Peter Rosin <[email protected]>
---
drivers/iio/dac/Kconfig | 2 +-
drivers/iio/dac/ti-dac5571.c | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index c0bf0d84197f..d6248b188645 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -417,7 +417,7 @@ config TI_DAC5571
help
Driver for the Texas Instruments
DAC5571, DAC6571, DAC7571, DAC5574, DAC6574, DAC7574, DAC5573,
- DAC6573, DAC7573, DAC8571, DAC8574.
+ DAC6573, DAC7573, DAC8571, DAC8574, DAC121C081.
If compiled as a module, it will be called ti-dac5571.
diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
index 4a3b8d875518..ce542bd8b69e 100644
--- a/drivers/iio/dac/ti-dac5571.c
+++ b/drivers/iio/dac/ti-dac5571.c
@@ -13,6 +13,7 @@
* https://www.ti.com/lit/ds/symlink/dac5573.pdf
* https://www.ti.com/lit/ds/symlink/dac6573.pdf
* https://www.ti.com/lit/ds/symlink/dac7573.pdf
+ * https://www.ti.com/lit/ds/symlink/dac121c081.pdf
*/
#include <linux/iio/iio.h>
@@ -394,6 +395,7 @@ static const struct of_device_id dac5571_of_id[] = {
{.compatible = "ti,dac5573"},
{.compatible = "ti,dac6573"},
{.compatible = "ti,dac7573"},
+ {.compatible = "ti,dac121c081"},
{}
};
MODULE_DEVICE_TABLE(of, dac5571_of_id);
@@ -408,6 +410,7 @@ static const struct i2c_device_id dac5571_id[] = {
{"dac5573", quad_8bit},
{"dac6573", quad_10bit},
{"dac7573", quad_12bit},
+ {"dac121c081", single_12bit},
{}
};
MODULE_DEVICE_TABLE(i2c, dac5571_id);
--
2.20.1
On Mon, 25 Apr 2022 22:46:30 +0200
Peter Rosin <[email protected]> wrote:
> Hi!
>
> The new chip works much like the other chips supported by the driver, so
> this is just adding another compatible to the list.
>
> Chenages since v1:
> - Guenter Roeck noticed elsewhere that my mail setup was botched and
> that my patches were clobbered. Hopefully fixed. *blush*
> - added tags from Sean Nyekjaer and Rob Herring
Applied. Thanks
Jonathan
>
> Cheers,
> Peter
>
> Peter Rosin (2):
> dt-bindings: iio: ti-dac5571: Add ti,dac121c081
> iio: dac: ti-dac5571: add support for ti,dac121c081
>
> Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> drivers/iio/dac/Kconfig | 2 +-
> drivers/iio/dac/ti-dac5571.c | 3 +++
> 3 files changed, 5 insertions(+), 1 deletion(-)
>
On Thu, 28 Apr 2022 20:44:39 +0100
Jonathan Cameron <[email protected]> wrote:
> On Mon, 25 Apr 2022 22:46:30 +0200
> Peter Rosin <[email protected]> wrote:
>
> > Hi!
> >
> > The new chip works much like the other chips supported by the driver, so
> > this is just adding another compatible to the list.
> >
> > Chenages since v1:
> > - Guenter Roeck noticed elsewhere that my mail setup was botched and
> > that my patches were clobbered. Hopefully fixed. *blush*
> > - added tags from Sean Nyekjaer and Rob Herring
>
> Applied. Thanks
Backed out temporarily because they have crossed with a fix (that I'd
forgotten about) and were requiring a non trivial merge in linux-next.
https://patchwork.kernel.org/project/linux-iio/patch/[email protected]/
Hopefully that will get resolved in my upstream fairly soon and I can
fix this one up whilst applying it myself.
Thanks,
Jonathan
>
> Jonathan
>
> >
> > Cheers,
> > Peter
> >
> > Peter Rosin (2):
> > dt-bindings: iio: ti-dac5571: Add ti,dac121c081
> > iio: dac: ti-dac5571: add support for ti,dac121c081
> >
> > Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> > drivers/iio/dac/Kconfig | 2 +-
> > drivers/iio/dac/ti-dac5571.c | 3 +++
> > 3 files changed, 5 insertions(+), 1 deletion(-)
> >
>
HI!
2022-05-01 at 20:03, Jonathan Cameron wrote:
> On Thu, 28 Apr 2022 20:44:39 +0100
> Jonathan Cameron <[email protected]> wrote:
>
>> On Mon, 25 Apr 2022 22:46:30 +0200
>> Peter Rosin <[email protected]> wrote:
>>
>>> Hi!
>>>
>>> The new chip works much like the other chips supported by the driver, so
>>> this is just adding another compatible to the list.
>>>
>>> Chenages since v1:
>>> - Guenter Roeck noticed elsewhere that my mail setup was botched and
>>> that my patches were clobbered. Hopefully fixed. *blush*
>>> - added tags from Sean Nyekjaer and Rob Herring
>>
>> Applied. Thanks
>
> Backed out temporarily because they have crossed with a fix (that I'd
> forgotten about) and were requiring a non trivial merge in linux-next.
>
> https://patchwork.kernel.org/project/linux-iio/patch/[email protected]/
>
> Hopefully that will get resolved in my upstream fairly soon and I can
> fix this one up whilst applying it myself.
Looks like it might be time to bring this one in from the cold?
Cheers,
Peter
On Thu, 12 May 2022 10:59:48 +0200
Peter Rosin <[email protected]> wrote:
> HI!
>
> 2022-05-01 at 20:03, Jonathan Cameron wrote:
> > On Thu, 28 Apr 2022 20:44:39 +0100
> > Jonathan Cameron <[email protected]> wrote:
> >
> >> On Mon, 25 Apr 2022 22:46:30 +0200
> >> Peter Rosin <[email protected]> wrote:
> >>
> >>> Hi!
> >>>
> >>> The new chip works much like the other chips supported by the driver, so
> >>> this is just adding another compatible to the list.
> >>>
> >>> Chenages since v1:
> >>> - Guenter Roeck noticed elsewhere that my mail setup was botched and
> >>> that my patches were clobbered. Hopefully fixed. *blush*
> >>> - added tags from Sean Nyekjaer and Rob Herring
> >>
> >> Applied. Thanks
> >
> > Backed out temporarily because they have crossed with a fix (that I'd
> > forgotten about) and were requiring a non trivial merge in linux-next.
> >
> > https://patchwork.kernel.org/project/linux-iio/patch/[email protected]/
> >
> > Hopefully that will get resolved in my upstream fairly soon and I can
> > fix this one up whilst applying it myself.
>
> Looks like it might be time to bring this one in from the cold?
Nearly. I have a pull request out to Greg. Once he's taken that
I'll fastforward the togreg branch to include the fix and
can then apply this.
Jonathan
>
> Cheers,
> Peter
On Thu, 12 May 2022 14:02:32 +0100
Jonathan Cameron <[email protected]> wrote:
> On Thu, 12 May 2022 10:59:48 +0200
> Peter Rosin <[email protected]> wrote:
>
> > HI!
> >
> > 2022-05-01 at 20:03, Jonathan Cameron wrote:
> > > On Thu, 28 Apr 2022 20:44:39 +0100
> > > Jonathan Cameron <[email protected]> wrote:
> > >
> > >> On Mon, 25 Apr 2022 22:46:30 +0200
> > >> Peter Rosin <[email protected]> wrote:
> > >>
> > >>> Hi!
> > >>>
> > >>> The new chip works much like the other chips supported by the driver, so
> > >>> this is just adding another compatible to the list.
> > >>>
> > >>> Chenages since v1:
> > >>> - Guenter Roeck noticed elsewhere that my mail setup was botched and
> > >>> that my patches were clobbered. Hopefully fixed. *blush*
> > >>> - added tags from Sean Nyekjaer and Rob Herring
> > >>
> > >> Applied. Thanks
> > >
> > > Backed out temporarily because they have crossed with a fix (that I'd
> > > forgotten about) and were requiring a non trivial merge in linux-next.
> > >
> > > https://patchwork.kernel.org/project/linux-iio/patch/[email protected]/
> > >
> > > Hopefully that will get resolved in my upstream fairly soon and I can
> > > fix this one up whilst applying it myself.
> >
> > Looks like it might be time to bring this one in from the cold?
>
> Nearly. I have a pull request out to Greg. Once he's taken that
> I'll fastforward the togreg branch to include the fix and
> can then apply this.
Now we are good. Applied to the togreg branch of iio.git and added the
tweak needed to provide data in the of_device_id table.
Unfortunately timing is against me this time, and unless the merge window
is delayed this is now 5.20 material.
Thanks,
Jonathan
>
> Jonathan
>
> >
> > Cheers,
> > Peter
>