2022-04-29 19:33:46

by CGEL

Subject: [PATCH] drm/amdgpu: simplify the return expression of iceland_ih_hw_init

From: Minghao Chi <[email protected]>

Simplify the return expression.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c b/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
index ddfe4eaeea05..aecad530b10a 100644
--- a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
+++ b/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
@@ -308,14 +308,9 @@ static int iceland_ih_sw_fini(void *handle)

static int iceland_ih_hw_init(void *handle)
{
- int r;
struct amdgpu_device *adev = (struct amdgpu_device *)handle;

- r = iceland_ih_irq_init(adev);
- if (r)
- return r;
-
- return 0;
+ return iceland_ih_irq_init(adev);
}

static int iceland_ih_hw_fini(void *handle)
--
2.25.1

2022-05-02 22:00:21

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu: simplify the return expression of iceland_ih_hw_init

Applied. Thanks!

On Fri, Apr 29, 2022 at 1:48 AM <[email protected]> wrote:
>
> From: Minghao Chi <[email protected]>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c b/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> index ddfe4eaeea05..aecad530b10a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> @@ -308,14 +308,9 @@ static int iceland_ih_sw_fini(void *handle)
>
> static int iceland_ih_hw_init(void *handle)
> {
> - int r;
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> - r = iceland_ih_irq_init(adev);
> - if (r)
> - return r;
> -
> - return 0;
> + return iceland_ih_irq_init(adev);
> }
>
> static int iceland_ih_hw_fini(void *handle)
> --
> 2.25.1
>
>