2022-04-29 17:06:46

by CGEL

Subject: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach

From: Minghao Chi <[email protected]>

Simplify the return expression.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/gpu/drm/bridge/parade-ps8640.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index edb939b14c04..e2467e58b5b7 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -542,7 +542,6 @@ static int ps8640_bridge_host_attach(struct device *dev, struct ps8640 *ps_bridg
struct device_node *in_ep, *dsi_node;
struct mipi_dsi_device *dsi;
struct mipi_dsi_host *host;
- int ret;
const struct mipi_dsi_device_info info = { .type = "ps8640",
.channel = 0,
.node = NULL,
@@ -577,11 +576,7 @@ static int ps8640_bridge_host_attach(struct device *dev, struct ps8640 *ps_bridg
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->lanes = NUM_MIPI_LANES;

- ret = devm_mipi_dsi_attach(dev, dsi);
- if (ret)
- return ret;
-
- return 0;
+ return devm_mipi_dsi_attach(dev, dsi);
}

static int ps8640_probe(struct i2c_client *client)
--
2.25.1

2022-04-29 19:58:59

by Doug Anderson

Subject: Re: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach

Hi,

On Thu, Apr 28, 2022 at 10:51 PM <[email protected]> wrote:
>
> From: Minghao Chi <[email protected]>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/gpu/drm/bridge/parade-ps8640.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: Douglas Anderson <[email protected]>

2022-05-10 21:53:12

by Doug Anderson

Subject: Re: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach

Hi,

On Fri, Apr 29, 2022 at 9:21 AM Doug Anderson <[email protected]> wrote:
>
> Hi,
>
> On Thu, Apr 28, 2022 at 10:51 PM <[email protected]> wrote:
> >
> > From: Minghao Chi <[email protected]>
> >
> > Simplify the return expression.
> >
> > Reported-by: Zeal Robot <[email protected]>
> > Signed-off-by: Minghao Chi <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/parade-ps8640.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
>
> Reviewed-by: Douglas Anderson <[email protected]>

Pushed to drm-misc-next:

e090532246fe drm/bridge: simplify the return expression of
ps8640_bridge_host_attach