2022-04-29 12:14:52

by Michal Suchánek

Subject: [PATCH] testing: nvdimm: asm/mce.h is not needed in nfit.c

asm/mce.h is not available on arm, and it is not needed to build nfit.c.
Remove the include.

It was likely needed for COPY_MC_TEST

Fixes: 3adb776384f2 ("x86, libnvdimm/test: Remove COPY_MC_TEST")
Signed-off-by: Michal Suchanek <[email protected]>
---
tools/testing/nvdimm/test/nfit.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
index 0bc91ffee257..b4743ba65b96 100644
--- a/tools/testing/nvdimm/test/nfit.c
+++ b/tools/testing/nvdimm/test/nfit.c
@@ -23,8 +23,6 @@
#include "nfit_test.h"
#include "../watermark.h"

-#include <asm/mce.h>
-
/*
* Generate an NFIT table to describe the following topology:
*
--
2.34.1

2022-05-03 00:39:14

by Dan Williams

Subject: Re: [PATCH] testing: nvdimm: asm/mce.h is not needed in nfit.c

On Fri, Apr 29, 2022 at 12:43 AM Michal Suchanek <[email protected]> wrote:
>
> asm/mce.h is not available on arm, and it is not needed to build nfit.c.
> Remove the include.
>
> It was likely needed for COPY_MC_TEST
>
> Fixes: 3adb776384f2 ("x86, libnvdimm/test: Remove COPY_MC_TEST")
> Signed-off-by: Michal Suchanek <[email protected]>

Yup, good catch, applied.