2022-05-03 01:05:46

by Konrad Dybcio

Subject: [PATCH] arm64: dts: qcom: msm8996: Add SDHCI resets

On MSM8996, the default bootloader configuration leaves the hosts in some
weird state that never allows them to function properly under Linux.
Add the hardware resets so that we can start clean and get them actually
working.

Signed-off-by: Konrad Dybcio <[email protected]>
---
Depends on [1], fixes eMMC on at least SONY Tone.

[1] https://patchwork.kernel.org/project/linux-mmc/patch/[email protected]/

arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index b9a48cfd760f..dc56830f9e00 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -2707,6 +2707,7 @@ sdhc1: sdhci@7464900 {
clocks = <&gcc GCC_SDCC1_AHB_CLK>,
<&gcc GCC_SDCC1_APPS_CLK>,
<&rpmcc RPM_SMD_BB_CLK1>;
+ resets = <&gcc GCC_SDCC1_BCR>;

pinctrl-names = "default", "sleep";
pinctrl-0 = <&sdc1_state_on>;
@@ -2730,6 +2731,7 @@ sdhc2: sdhci@74a4900 {
clocks = <&gcc GCC_SDCC2_AHB_CLK>,
<&gcc GCC_SDCC2_APPS_CLK>,
<&rpmcc RPM_SMD_BB_CLK1>;
+ resets = <&gcc GCC_SDCC2_BCR>;

pinctrl-names = "default", "sleep";
pinctrl-0 = <&sdc2_state_on>;
--
2.35.2

2022-06-28 20:49:27

by Bjorn Andersson

Subject: Re: (subset) [PATCH] arm64: dts: qcom: msm8996: Add SDHCI resets

On Sat, 30 Apr 2022 18:26:42 +0200, Konrad Dybcio wrote:
> On MSM8996, the default bootloader configuration leaves the hosts in some
> weird state that never allows them to function properly under Linux.
> Add the hardware resets so that we can start clean and get them actually
> working.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: msm8996: Add SDHCI resets
commit: 68333a42fcf53f20aa09567f8b57216438cdd2f6

Best regards,
--
Bjorn Andersson <[email protected]>