tree: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
head: acbb6b34258ea867c21d47ab53934ef9dbc442a0
commit: a50dfa903391d542025a92c92606425fbccc8323 [31/32] platform/x86: thinkpad_acpi: Add a s2idle resume quirk for a number of laptops
config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20220504/[email protected]/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=a50dfa903391d542025a92c92606425fbccc8323
git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
git fetch --no-tags pdx86-platform-drivers-x86 review-hans
git checkout a50dfa903391d542025a92c92606425fbccc8323
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
sparse warnings: (new ones prefixed by >>)
drivers/platform/x86/thinkpad_acpi.c:318:20: sparse: sparse: symbol 'quirk_btusb_bug' was not declared. Should it be static?
>> drivers/platform/x86/thinkpad_acpi.c:322:20: sparse: sparse: symbol 'quirk_s2idle_bug' was not declared. Should it be static?
Please review and possibly fold the followup patch.
--
0-DAY CI Kernel Test Service
https://01.org/lkp
drivers/platform/x86/thinkpad_acpi.c:322:20: warning: symbol 'quirk_s2idle_bug' was not declared. Should it be static?
Fixes: a50dfa903391 ("platform/x86: thinkpad_acpi: Add a s2idle resume quirk for a number of laptops")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index f385450af8647..d5431d3d4246f 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -319,7 +319,7 @@ struct quirk_entry quirk_btusb_bug = {
.btusb_bug = true,
};
-struct quirk_entry quirk_s2idle_bug = {
+static struct quirk_entry quirk_s2idle_bug = {
.s2idle_bug_mmio = 0xfed80380,
};
Hi,
On 5/3/22 20:21, kernel test robot wrote:
> drivers/platform/x86/thinkpad_acpi.c:322:20: warning: symbol 'quirk_s2idle_bug' was not declared. Should it be static?
>
> Fixes: a50dfa903391 ("platform/x86: thinkpad_acpi: Add a s2idle resume quirk for a number of laptops")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: kernel test robot <[email protected]>
Thanks, since the original patch was still in my review-hans
branch (and not yet in for-next) I've squashed this fix into
the original patch.
Regards,
Hans
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index f385450af8647..d5431d3d4246f 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -319,7 +319,7 @@ struct quirk_entry quirk_btusb_bug = {
> .btusb_bug = true,
> };
>
> -struct quirk_entry quirk_s2idle_bug = {
> +static struct quirk_entry quirk_s2idle_bug = {
> .s2idle_bug_mmio = 0xfed80380,
> };
>
>