On Mon, May 09, 2022 at 01:16:28AM +0800, kernel test robot wrote:
> Hi "Jos?,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on hid/for-next]
> [cannot apply to v5.18-rc5 next-20220506]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
Missing --base=<commit> argument, the patch applies without issues on
for-5.19/uclogic.
Let me now if you need me to resend it,
Jose
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Jos-Exp-sito/DIGImend-patches-part-VI/20220509-000510
> base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220509/[email protected]/config)
> compiler: m68k-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/4c0671e4ce0687136ff71aa65539cd3a2798d99d
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Jos-Exp-sito/DIGImend-patches-part-VI/20220509-000510
> git checkout 4c0671e4ce0687136ff71aa65539cd3a2798d99d
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/hid/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/hid/hid-uclogic-params.c:48: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Dump tablet interface pen parameters with hid_dbg(), indented with one tab.
> drivers/hid/hid-uclogic-params.c:80: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Dump tablet interface frame parameters with hid_dbg(), indented with two
> drivers/hid/hid-uclogic-params.c:105: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Dump tablet interface parameters with hid_dbg().
>
>
> vim +48 drivers/hid/hid-uclogic-params.c
>
> 46
> 47 /**
> > 48 * Dump tablet interface pen parameters with hid_dbg(), indented with one tab.
> 49 *
> 50 * @hdev: The HID device the pen parameters describe.
> 51 * @pen: The pen parameters to dump.
> 52 */
> 53 static void uclogic_params_pen_hid_dbg(const struct hid_device *hdev,
> 54 const struct uclogic_params_pen *pen)
> 55 {
> 56 size_t i;
> 57
> 58 hid_dbg(hdev, "\t.usage_invalid = %s\n",
> 59 (pen->usage_invalid ? "true" : "false"));
> 60 hid_dbg(hdev, "\t.desc_ptr = %p\n", pen->desc_ptr);
> 61 hid_dbg(hdev, "\t.desc_size = %u\n", pen->desc_size);
> 62 hid_dbg(hdev, "\t.id = %u\n", pen->id);
> 63 hid_dbg(hdev, "\t.subreport_list = {\n");
> 64 for (i = 0; i < ARRAY_SIZE(pen->subreport_list); i++) {
> 65 hid_dbg(hdev, "\t\t{0x%02hhx, %hhu}%s\n",
> 66 pen->subreport_list[i].value,
> 67 pen->subreport_list[i].id,
> 68 i < (ARRAY_SIZE(pen->subreport_list) - 1) ? "," : "");
> 69 }
> 70 hid_dbg(hdev, "\t}\n");
> 71 hid_dbg(hdev, "\t.inrange = %s\n",
> 72 uclogic_params_pen_inrange_to_str(pen->inrange));
> 73 hid_dbg(hdev, "\t.fragmented_hires = %s\n",
> 74 (pen->fragmented_hires ? "true" : "false"));
> 75 hid_dbg(hdev, "\t.tilt_y_flipped = %s\n",
> 76 (pen->tilt_y_flipped ? "true" : "false"));
> 77 }
> 78
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp