2022-05-14 02:38:01

by Alex Elder

[permalink] [raw]
Subject: [PATCH net 0/3] net: ipa: three bug fixes

This series contains three somewhat unrelated minor bug fixes.

-Alex

Alex Elder (3):
net: ipa: certain dropped packets aren't accounted for
net: ipa: record proper RX transaction count
net: ipa: get rid of a duplicate initialization

drivers/net/ipa/gsi.c | 6 ++++--
drivers/net/ipa/ipa_endpoint.c | 13 ++++++-------
drivers/net/ipa/ipa_qmi.c | 2 +-
3 files changed, 11 insertions(+), 10 deletions(-)

--
2.32.0



2022-05-14 03:29:56

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net 0/3] net: ipa: three bug fixes

Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Thu, 12 May 2022 10:10:30 -0500 you wrote:
> This series contains three somewhat unrelated minor bug fixes.
>
> -Alex
>
> Alex Elder (3):
> net: ipa: certain dropped packets aren't accounted for
> net: ipa: record proper RX transaction count
> net: ipa: get rid of a duplicate initialization
>
> [...]

Here is the summary with links:
- [net,1/3] net: ipa: certain dropped packets aren't accounted for
https://git.kernel.org/netdev/net/c/30b338ff7998
- [net,2/3] net: ipa: record proper RX transaction count
https://git.kernel.org/netdev/net/c/d8290cbe1111
- [net,3/3] net: ipa: get rid of a duplicate initialization
https://git.kernel.org/netdev/net/c/8d017efb1eaa

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



2022-05-14 04:19:00

by Alex Elder

[permalink] [raw]
Subject: [PATCH net 3/3] net: ipa: get rid of a duplicate initialization

In ipa_qmi_ready(), the "ipa" local variable is set when
initialized, but then set again just before it's first used.
One or the other is enough, so get rid of the first one.

References: https://lore.kernel.org/lkml/[email protected]/
Reported-by: kernel test robot <[email protected]>
Fixes: 530f9216a953 ("soc: qcom: ipa: AP/modem communications")
Signed-off-by: Alex Elder <[email protected]>
---
drivers/net/ipa/ipa_qmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c
index 90f3aec55b365..ec010cf2e816a 100644
--- a/drivers/net/ipa/ipa_qmi.c
+++ b/drivers/net/ipa/ipa_qmi.c
@@ -125,7 +125,7 @@ static void ipa_qmi_indication(struct ipa_qmi *ipa_qmi)
*/
static void ipa_qmi_ready(struct ipa_qmi *ipa_qmi)
{
- struct ipa *ipa = container_of(ipa_qmi, struct ipa, qmi);
+ struct ipa *ipa;
int ret;

/* We aren't ready until the modem and microcontroller are */
--
2.32.0