While updating the Lantiq target in OpenWrt to Linux 5.15 I came across
an FDB related error message. While that still needs to be solved I
found two other small issues on the way.
This series fixes the two minor issues found while revisiting the FDB
code in the lantiq_gswip driver:
- The first patch fixes the start index used in gswip_port_fdb() to
find the entry with the matching bridge. The updated logic is now
consistent with the rest of the driver.
- The second patch fixes a typo in a dev_err() message.
Hauke gave his Acked-by off-list to me before I sent the patches.
Changes since v1 at [0]:
- rebased on top of net-next as none of the patches requires backporting
to -stable
- added Vladimir's Reviewed-by to the second patch (thank you!)
[0] https://lore.kernel.org/netdev/[email protected]/
Martin Blumenstingl (2):
net: dsa: lantiq_gswip: Fix start index in gswip_port_fdb()
net: dsa: lantiq_gswip: Fix typo in gswip_port_fdb_dump() error print
drivers/net/dsa/lantiq_gswip.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.36.1
gswip_port_fdb_dump() reads the MAC bridge entries. The error message
should say "failed to read mac bridge entry". While here, also add the
index to the error print so humans can get to the cause of the problem
easier.
Fixes: 58c59ef9e930c4 ("net: dsa: lantiq: Add Forwarding Database access")
Acked-by: Hauke Mehrtens <[email protected]>
Reviewed-by: Vladimir Oltean <[email protected]>
Signed-off-by: Martin Blumenstingl <[email protected]>
---
drivers/net/dsa/lantiq_gswip.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 0c313db23451..8af4def38a98 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -1426,8 +1426,9 @@ static int gswip_port_fdb_dump(struct dsa_switch *ds, int port,
err = gswip_pce_table_entry_read(priv, &mac_bridge);
if (err) {
- dev_err(priv->dev, "failed to write mac bridge: %d\n",
- err);
+ dev_err(priv->dev,
+ "failed to read mac bridge entry %d: %d\n",
+ i, err);
return err;
}
--
2.36.1
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:
On Thu, 19 May 2022 00:00:49 +0200 you wrote:
> While updating the Lantiq target in OpenWrt to Linux 5.15 I came across
> an FDB related error message. While that still needs to be solved I
> found two other small issues on the way.
>
> This series fixes the two minor issues found while revisiting the FDB
> code in the lantiq_gswip driver:
> - The first patch fixes the start index used in gswip_port_fdb() to
> find the entry with the matching bridge. The updated logic is now
> consistent with the rest of the driver.
> - The second patch fixes a typo in a dev_err() message.
>
> [...]
Here is the summary with links:
- [net-next,v2,1/2] net: dsa: lantiq_gswip: Fix start index in gswip_port_fdb()
https://git.kernel.org/netdev/net-next/c/7b4149bdee6a
- [net-next,v2,2/2] net: dsa: lantiq_gswip: Fix typo in gswip_port_fdb_dump() error print
https://git.kernel.org/netdev/net-next/c/4951995dbe9d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html