2022-05-26 18:26:44

by Marco Pagani

Subject: [PATCH v2] fpga: altera-pr-ip: fix unsigned comparison with less than zero

Fix the "comparison with less than zero" warning reported by
cppcheck for the unsigned (size_t) parameter count of the
alt_pr_fpga_write() function.

Reviewed-by: Tom Rix <[email protected]>
Acked-by: Xu Yilun <[email protected]>
Signed-off-by: Marco Pagani <[email protected]>
---
Changes v1 -> v2:
- Coding style fix
---
drivers/fpga/altera-pr-ip-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
index be0667968d33..df8671af4a92 100644
--- a/drivers/fpga/altera-pr-ip-core.c
+++ b/drivers/fpga/altera-pr-ip-core.c
@@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
u32 *buffer_32 = (u32 *)buf;
size_t i = 0;

- if (count <= 0)
+ if (!count)
return -EINVAL;

/* Write out the complete 32-bit chunks */
--
2.35.3

2022-06-08 08:32:30

by Xu Yilun

Subject: Re: [PATCH v2] fpga: altera-pr-ip: fix unsigned comparison with less than zero

On Wed, May 25, 2022 at 05:14:52PM +0200, Marco Pagani wrote:
> Fix the "comparison with less than zero" warning reported by
> cppcheck for the unsigned (size_t) parameter count of the
> alt_pr_fpga_write() function.
>

Please add the 'Fixes' tag, and resend it based on 5.19-rc1

Thanks,
Yilun

> Reviewed-by: Tom Rix <[email protected]>
> Acked-by: Xu Yilun <[email protected]>
> Signed-off-by: Marco Pagani <[email protected]>
> ---
> Changes v1 -> v2:
> - Coding style fix
> ---
> drivers/fpga/altera-pr-ip-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
> index be0667968d33..df8671af4a92 100644
> --- a/drivers/fpga/altera-pr-ip-core.c
> +++ b/drivers/fpga/altera-pr-ip-core.c
> @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
> u32 *buffer_32 = (u32 *)buf;
> size_t i = 0;
>
> - if (count <= 0)
> + if (!count)
> return -EINVAL;
>
> /* Write out the complete 32-bit chunks */
> --
> 2.35.3