2022-05-26 19:20:50

by Uwe Kleine-König

Subject: [PATCH] extcon: fsa9480: Drop no-op remove function

A remove callback that just returns 0 is equivalent to no callback at all
as can be seen in i2c_device_remove(). So simplify accordingly.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/extcon/extcon-fsa9480.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c
index 08bdedbcdb0d..7cff66c29907 100644
--- a/drivers/extcon/extcon-fsa9480.c
+++ b/drivers/extcon/extcon-fsa9480.c
@@ -324,11 +324,6 @@ static int fsa9480_probe(struct i2c_client *client,
return 0;
}

-static int fsa9480_remove(struct i2c_client *client)
-{
- return 0;
-}
-
#ifdef CONFIG_PM_SLEEP
static int fsa9480_suspend(struct device *dev)
{
@@ -376,7 +371,6 @@ static struct i2c_driver fsa9480_i2c_driver = {
.of_match_table = fsa9480_of_match,
},
.probe = fsa9480_probe,
- .remove = fsa9480_remove,
.id_table = fsa9480_id,
};


base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
--
2.36.1

2022-05-28 19:52:56

by Chanwoo Choi

Subject: Re: [PATCH] extcon: fsa9480: Drop no-op remove function

On 5/26/22 10:07 PM, Uwe Kleine-König wrote:
> A remove callback that just returns 0 is equivalent to no callback at all
> as can be seen in i2c_device_remove(). So simplify accordingly.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
> drivers/extcon/extcon-fsa9480.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c
> index 08bdedbcdb0d..7cff66c29907 100644
> --- a/drivers/extcon/extcon-fsa9480.c
> +++ b/drivers/extcon/extcon-fsa9480.c
> @@ -324,11 +324,6 @@ static int fsa9480_probe(struct i2c_client *client,
> return 0;
> }
>
> -static int fsa9480_remove(struct i2c_client *client)
> -{
> - return 0;
> -}
> -
> #ifdef CONFIG_PM_SLEEP
> static int fsa9480_suspend(struct device *dev)
> {
> @@ -376,7 +371,6 @@ static struct i2c_driver fsa9480_i2c_driver = {
> .of_match_table = fsa9480_of_match,
> },
> .probe = fsa9480_probe,
> - .remove = fsa9480_remove,
> .id_table = fsa9480_id,
> };
>
>
> base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
>

Applied it for v5.20-rc1. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics