2022-06-08 05:25:53

by Potin Lai

Subject: [PATCH v3 2/2] dt-bindings: aspeed-i2c: add properties for setting i2c clock duty cycle

Introduce a new property for setting a minimum duty cycle for clock high.

* i2c-clk-duty-cycle-min: a minimum percentage of clock high

Signed-off-by: Potin Lai <[email protected]>
---
Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
index ea643e6c3ef5..af4c49111cc0 100644
--- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
@@ -49,6 +49,14 @@ properties:
description:
states that there is another master active on this bus

+ i2c-clk-duty-cycle-min:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 1
+ maximum: 100
+ default: 50
+ description:
+ a minimum percentage of clock high
+
required:
- reg
- compatible
--
2.17.1

2022-06-09 20:49:45

by Rob Herring

Subject: Re: [PATCH v3 2/2] dt-bindings: aspeed-i2c: add properties for setting i2c clock duty cycle

On Wed, Jun 08, 2022 at 12:37:03AM +0800, Potin Lai wrote:
> Introduce a new property for setting a minimum duty cycle for clock high.
>
> * i2c-clk-duty-cycle-min: a minimum percentage of clock high
>
> Signed-off-by: Potin Lai <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> index ea643e6c3ef5..af4c49111cc0 100644
> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -49,6 +49,14 @@ properties:
> description:
> states that there is another master active on this bus
>
> + i2c-clk-duty-cycle-min:

i2c-clk-duty-cycle-high-min-percent

Or maybe 'i2c-clk-high-min-percent' with duty cycle being implied.

> + $ref: /schemas/types.yaml#/definitions/uint32

With '-percent' you can drop this.

> + minimum: 1
> + maximum: 100
> + default: 50
> + description:
> + a minimum percentage of clock high
> +
> required:
> - reg
> - compatible
> --
> 2.17.1
>
>