2022-06-08 07:29:09

by Yang Li

Subject: [PATCH -next] btrfs: Remove the unused function scrub_calc_parity_bitmap_len()

bitmap_len = scrub_calc_parity_bitmap_len(), the only call point of this
function has been deleted, so it should also be removed.

Fix the following W=1 kernel warning:
fs/btrfs/scrub.c:2857:19: warning: unused function 'scrub_calc_parity_bitmap_len'

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
fs/btrfs/scrub.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index 46cac7c7f292..db700e6ec5a9 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -2854,11 +2854,6 @@ static void scrub_parity_check_and_repair(struct scrub_parity *sparity)
scrub_free_parity(sparity);
}

-static inline int scrub_calc_parity_bitmap_len(int nsectors)
-{
- return DIV_ROUND_UP(nsectors, BITS_PER_LONG) * sizeof(long);
-}
-
static void scrub_parity_get(struct scrub_parity *sparity)
{
refcount_inc(&sparity->refs);
--
2.20.1.7.g153144c

2022-06-08 22:01:46

by David Sterba

Subject: Re: [PATCH -next] btrfs: Remove the unused function scrub_calc_parity_bitmap_len()

On Wed, Jun 08, 2022 at 09:21:58AM +0800, Yang Li wrote:
> bitmap_len = scrub_calc_parity_bitmap_len(), the only call point of this
> function has been deleted, so it should also be removed.
>
> Fix the following W=1 kernel warning:
> fs/btrfs/scrub.c:2857:19: warning: unused function 'scrub_calc_parity_bitmap_len'
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Thanks, fix folded to the patch as it's still in the development branch.