2022-06-16 06:25:34

by Samuel Holland

Subject: [PATCH 1/4] dt-bindings: gpio: Add AXP221/AXP223/AXP809 compatibles

These PMICs each have 2 GPIOs with the same register layout as AXP813,
but without an ADC function.

Signed-off-by: Samuel Holland <[email protected]>
---

.../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml b/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
index 0f628b088cec..6faa3ef28960 100644
--- a/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
@@ -19,7 +19,14 @@ properties:
oneOf:
- enum:
- x-powers,axp209-gpio
+ - x-powers,axp221-gpio
- x-powers,axp813-gpio
+ - items:
+ - const: x-powers,axp223-gpio
+ - const: x-powers,axp221-gpio
+ - items:
+ - const: x-powers,axp809-gpio
+ - const: x-powers,axp221-gpio
- items:
- const: x-powers,axp803-gpio
- const: x-powers,axp813-gpio
--
2.35.1

2022-06-16 14:48:08

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/4] dt-bindings: gpio: Add AXP221/AXP223/AXP809 compatibles

On 15/06/2022 23:09, Samuel Holland wrote:
> These PMICs each have 2 GPIOs with the same register layout as AXP813,
> but without an ADC function.
>
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml b/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> index 0f628b088cec..6faa3ef28960 100644
> --- a/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> @@ -19,7 +19,14 @@ properties:
> oneOf:
> - enum:
> - x-powers,axp209-gpio
> + - x-powers,axp221-gpio
> - x-powers,axp813-gpio
> + - items:
> + - const: x-powers,axp223-gpio
> + - const: x-powers,axp221-gpio
> + - items:
> + - const: x-powers,axp809-gpio

This is just an enum with 223 and 809. No need for two separate entries
here.

> + - const: x-powers,axp221-gpio
> - items:
> - const: x-powers,axp803-gpio
> - const: x-powers,axp813-gpio


Best regards,
Krzysztof