2022-06-20 11:21:21

by Alain Volmat

[permalink] [raw]
Subject: [PATCH 0/4] i2c: stm32: addition of STM32MP13 support

This series adds the support for the stm32mp13.

Alain Volmat (4):
dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line
i2c: stm32: only perform a reset if there is a reset property
dt-bindings: i2c: st,stm32-i2c: add entry for stm32mp13
i2c: stm32: add support for the STM32MP13 soc

.../devicetree/bindings/i2c/st,stm32-i2c.yaml | 3 ++-
drivers/i2c/busses/i2c-stm32f7.c | 20 +++++++++++++------
2 files changed, 16 insertions(+), 7 deletions(-)

--
2.25.1


2022-06-20 11:25:24

by Alain Volmat

[permalink] [raw]
Subject: [PATCH 3/4] dt-bindings: i2c: st,stm32-i2c: add entry for stm32mp13

Add the new compatible for the stm32mp13.

Signed-off-by: Alain Volmat <[email protected]>
---
Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
index 8879144fbbfb..d8ecfb39dc01 100644
--- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
@@ -17,6 +17,7 @@ allOf:
contains:
enum:
- st,stm32f7-i2c
+ - st,stm32mp13-i2c
- st,stm32mp15-i2c
then:
properties:
@@ -45,6 +46,7 @@ properties:
enum:
- st,stm32f4-i2c
- st,stm32f7-i2c
+ - st,stm32mp13-i2c
- st,stm32mp15-i2c

reg:
--
2.25.1

2022-06-20 11:46:49

by Alain Volmat

[permalink] [raw]
Subject: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line

Update the dt-bindings of the i2c-stm32 drivers to avoid the
needs for a reset property in the device-tree.

Signed-off-by: Alain Volmat <[email protected]>
---
Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
index dccbb18b6dc0..8879144fbbfb 100644
--- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
@@ -94,7 +94,6 @@ required:
- compatible
- reg
- interrupts
- - resets
- clocks

unevaluatedProperties: false
--
2.25.1

2022-06-28 14:09:18

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line

On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> Update the dt-bindings of the i2c-stm32 drivers to avoid the
> needs for a reset property in the device-tree.

That is clear from the diff, but why. Some chips don't have a reset?
If so, this should be combined with patch 2 as part of changes needed
for a new version.

>
> Signed-off-by: Alain Volmat <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> index dccbb18b6dc0..8879144fbbfb 100644
> --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> @@ -94,7 +94,6 @@ required:
> - compatible
> - reg
> - interrupts
> - - resets
> - clocks
>
> unevaluatedProperties: false
> --
> 2.25.1
>
>

2022-06-29 19:48:45

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line

On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > needs for a reset property in the device-tree.
>
> That is clear from the diff, but why. Some chips don't have a reset?
> If so, this should be combined with patch 2 as part of changes needed
> for a new version.

What do you mean? Patches 1+2 should be squashed together? I can do this
when applying. Or do you mean something else?

>
> >
> > Signed-off-by: Alain Volmat <[email protected]>
> > ---
> > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > index dccbb18b6dc0..8879144fbbfb 100644
> > --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > @@ -94,7 +94,6 @@ required:
> > - compatible
> > - reg
> > - interrupts
> > - - resets
> > - clocks
> >
> > unevaluatedProperties: false
> > --
> > 2.25.1
> >
> >


Attachments:
(No filename) (1.21 kB)
signature.asc (849.00 B)
Download all attachments

2022-07-06 23:23:33

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line

On Wed, Jun 29, 2022 at 09:44:37PM +0200, Wolfram Sang wrote:
> On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> > On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > > needs for a reset property in the device-tree.
> >
> > That is clear from the diff, but why. Some chips don't have a reset?
> > If so, this should be combined with patch 2 as part of changes needed
> > for a new version.
>
> What do you mean? Patches 1+2 should be squashed together? I can do this
> when applying. Or do you mean something else?

Sorry, I meant combined with patch 3. If the new chip added in patch 3
doesn't have a reset, then 1 and 3 should be 1 patch. IOW, all the
changes needed for a new chip in 1 patch.

Rob

2022-07-07 06:47:25

by Alain Volmat

[permalink] [raw]
Subject: Re: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line

Hi Rob,

On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > needs for a reset property in the device-tree.
>
> That is clear from the diff, but why. Some chips don't have a reset?
> If so, this should be combined with patch 2 as part of changes needed
> for a new version.

Alexandre has just pushed a pull-request enabling support for the
clock/reset [1] so I will shortly push a v2 of the serie dropping the
first 2 patches.

Thanks
Alain

[1] https://lore.kernel.org/all/[email protected]/

>
> >
> > Signed-off-by: Alain Volmat <[email protected]>
> > ---
> > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > index dccbb18b6dc0..8879144fbbfb 100644
> > --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > @@ -94,7 +94,6 @@ required:
> > - compatible
> > - reg
> > - interrupts
> > - - resets
> > - clocks
> >
> > unevaluatedProperties: false
> > --
> > 2.25.1
> >
> >