On 21.06.2022 20:07:49, Francesco Dolcini wrote:
> Hello Shawn, just a ping on this.
>
> Francesco
>
> On Thu, May 12, 2022 at 12:40:19PM +0200, Andrejs Cainikovs wrote:
> > Update SPI CAN controller clock to match current hardware design.
> >
> > Signed-off-by: Andrejs Cainikovs <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > index 0d84d29e70f1..d309bc0ab8f6 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> > @@ -32,10 +32,10 @@ backlight: backlight {
> > };
> >
> > /* Fixed clock dedicated to SPI CAN controller */
> > - clk20m: oscillator {
> > + clk40m: oscillator {
> > compatible = "fixed-clock";
> > #clock-cells = <0>;
> > - clock-frequency = <20000000>;
> > + clock-frequency = <40000000>;
> > };
> >
> > gpio-keys {
> > @@ -194,7 +194,7 @@ &ecspi3 {
> >
> > can1: can@0 {
> > compatible = "microchip,mcp251xfd";
> > - clocks = <&clk20m>;
> > + clocks = <&clk40m>;
> > interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_FALLING>;
You don't want to use an edge triggered interrupt with the mcp251xfd
chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |