2022-06-24 18:47:46

by Rob Clark

Subject: [PATCH] drm/msm/gem: Fix error return on fence id alloc fail

From: Rob Clark <[email protected]>

This was a typo, we didn't actually want to return zero.

Fixes: a61acbbe9cf8 ("drm/msm: Track "seqno" fences by idr")
Signed-off-by: Rob Clark <[email protected]>
---
drivers/gpu/drm/msm/msm_gem_submit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c
index 3c3a0cfade36..c9e4aeb14f4a 100644
--- a/drivers/gpu/drm/msm/msm_gem_submit.c
+++ b/drivers/gpu/drm/msm/msm_gem_submit.c
@@ -928,7 +928,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
INT_MAX, GFP_KERNEL);
}
if (submit->fence_id < 0) {
- ret = submit->fence_id = 0;
+ ret = submit->fence_id;
submit->fence_id = 0;
}

--
2.36.1

2022-06-25 01:05:26

by Dmitry Baryshkov

Subject: Re: [PATCH] drm/msm/gem: Fix error return on fence id alloc fail

On Fri, 24 Jun 2022 at 21:45, Rob Clark <[email protected]> wrote:
>
> From: Rob Clark <[email protected]>
>
> This was a typo, we didn't actually want to return zero.
>
> Fixes: a61acbbe9cf8 ("drm/msm: Track "seqno" fences by idr")
> Signed-off-by: Rob Clark <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>


--
With best wishes
Dmitry