2022-07-08 10:54:19

by Andre Przywara

Subject: [PATCH v13 1/7] dt-bindings: arm: sunxi: Add H616 EMAC compatible

The Allwinner H616 contains an "EMAC" Ethernet MAC compatible to the A64
version.

Add it to the list of compatible strings.

Signed-off-by: Andre Przywara <[email protected]>
Acked-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
index 6a4831fd3616c..87f1306831cc9 100644
--- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
+++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
@@ -22,6 +22,7 @@ properties:
- enum:
- allwinner,sun20i-d1-emac
- allwinner,sun50i-h6-emac
+ - allwinner,sun50i-h616-emac
- const: allwinner,sun50i-a64-emac

reg:
--
2.25.1

2022-07-09 16:54:05

by Samuel Holland

Subject: Re: [PATCH v13 1/7] dt-bindings: arm: sunxi: Add H616 EMAC compatible

Hi Andre,

On 7/8/22 5:52 AM, Andre Przywara wrote:
> The Allwinner H616 contains an "EMAC" Ethernet MAC compatible to the A64
> version.

H616 contains two EMACs, and only EMAC0 is compatible to the A64 version. EMAC1
requires an updated driver that knows about the different syscon register
location. So the new compatible string should be limited to EMAC0, i.e.
allwinner,sun50i-h616-emac0.

Regards,
Samuel

> Add it to the list of compatible strings.
>
> Signed-off-by: Andre Przywara <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> ---
> .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> index 6a4831fd3616c..87f1306831cc9 100644
> --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> @@ -22,6 +22,7 @@ properties:
> - enum:
> - allwinner,sun20i-d1-emac
> - allwinner,sun50i-h6-emac
> + - allwinner,sun50i-h616-emac
> - const: allwinner,sun50i-a64-emac
>
> reg:
>