2022-07-11 16:00:51

by Akhil R

Subject: [PATCH v3 1/3] dt-bindings: dmaengine: Add compatible for Tegra234

Document the compatible string used by GPCDMA controller for Tegra234.

Signed-off-by: Akhil R <[email protected]>
---
.../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
index 9dd1476d1849..399edcd5cecf 100644
--- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
@@ -26,6 +26,10 @@ properties:
- const: nvidia,tegra194-gpcdma
- const: nvidia,tegra186-gpcdma

+ - items:
+ - const: nvidia,tegra234-gpcdma
+ - const: nvidia,tegra186-gpcdma
+
"#dma-cells":
const: 1

--
2.17.1

2022-07-13 15:36:24

by Jon Hunter

Subject: Re: [PATCH v3 1/3] dt-bindings: dmaengine: Add compatible for Tegra234

On 11/07/2022 16:45, Akhil R wrote:
> Document the compatible string used by GPCDMA controller for Tegra234.
>
> Signed-off-by: Akhil R <[email protected]>
> ---
> .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index 9dd1476d1849..399edcd5cecf 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -26,6 +26,10 @@ properties:
> - const: nvidia,tegra194-gpcdma
> - const: nvidia,tegra186-gpcdma
>
> + - items:
> + - const: nvidia,tegra234-gpcdma
> + - const: nvidia,tegra186-gpcdma
> +
> "#dma-cells":
> const: 1
>


Reviewed-by: Jon Hunter <[email protected]>

Cheers
Jon

--
nvpublic

2022-07-18 19:30:48

by Rob Herring

Subject: Re: [PATCH v3 1/3] dt-bindings: dmaengine: Add compatible for Tegra234

On Mon, Jul 11, 2022 at 09:15:34PM +0530, Akhil R wrote:
> Document the compatible string used by GPCDMA controller for Tegra234.
>
> Signed-off-by: Akhil R <[email protected]>
> ---
> .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index 9dd1476d1849..399edcd5cecf 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -26,6 +26,10 @@ properties:
> - const: nvidia,tegra194-gpcdma
> - const: nvidia,tegra186-gpcdma
>
> + - items:
> + - const: nvidia,tegra234-gpcdma

This can be added to the above entry changing it from a const to enum.

> + - const: nvidia,tegra186-gpcdma
> +
> "#dma-cells":
> const: 1
>
> --
> 2.17.1
>
>

2022-07-19 08:07:29

by Akhil R

Subject: RE: [PATCH v3 1/3] dt-bindings: dmaengine: Add compatible for Tegra234

> On Mon, Jul 11, 2022 at 09:15:34PM +0530, Akhil R wrote:
> > Document the compatible string used by GPCDMA controller for Tegra234.
> >
> > Signed-off-by: Akhil R <[email protected]>
> > ---
> > .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-
> dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-
> dma.yaml
> > index 9dd1476d1849..399edcd5cecf 100644
> > --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-
> dma.yaml
> > @@ -26,6 +26,10 @@ properties:
> > - const: nvidia,tegra194-gpcdma
> > - const: nvidia,tegra186-gpcdma
> >
> > + - items:
> > + - const: nvidia,tegra234-gpcdma
>
> This can be added to the above entry changing it from a const to enum.
>
So, it could look like this, correct?

compatible:
oneOf:
- const: nvidia,tegra186-gpcdma
- items:
- enum:
- nvidia,tegra234-gpcdma
- nvidia,tegra194-gpcdma
- const: nvidia,tegra186-gpcdma

Tried dt_binding_check and dtbs_check with this change and did not see any error.

Regards,
Akhil

--
nvpublic