2022-07-15 14:17:56

by Maksym Glubokiy

Subject: [PATCH net] net: prestera: acl: use proper mask for port selector

Adjusted as per packet processor documentation.
This allows to properly match 'indev' for clsact rules.

Fixes: 47327e198d42 ("net: prestera: acl: migrate to new vTCAM api")

Signed-off-by: Maksym Glubokiy <[email protected]>
---
drivers/net/ethernet/marvell/prestera/prestera_flower.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_flower.c b/drivers/net/ethernet/marvell/prestera/prestera_flower.c
index d43e503c644f..4d93ad6a284c 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_flower.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_flower.c
@@ -167,12 +167,12 @@ static int prestera_flower_parse_meta(struct prestera_acl_rule *rule,
}
port = netdev_priv(ingress_dev);

- mask = htons(0x1FFF);
- key = htons(port->hw_id);
+ mask = htons(0x1FFF << 3);
+ key = htons(port->hw_id << 3);
rule_match_set(r_match->key, SYS_PORT, key);
rule_match_set(r_match->mask, SYS_PORT, mask);

- mask = htons(0x1FF);
+ mask = htons(0x3FF);
key = htons(port->dev_id);
rule_match_set(r_match->key, SYS_DEV, key);
rule_match_set(r_match->mask, SYS_DEV, mask);
--
2.25.1

2022-07-18 11:10:43

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: prestera: acl: use proper mask for port selector

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Fri, 15 Jul 2022 15:55:50 +0300 you wrote:
> Adjusted as per packet processor documentation.
> This allows to properly match 'indev' for clsact rules.
>
> Fixes: 47327e198d42 ("net: prestera: acl: migrate to new vTCAM api")
>
> Signed-off-by: Maksym Glubokiy <[email protected]>
>
> [...]

Here is the summary with links:
- [net] net: prestera: acl: use proper mask for port selector
https://git.kernel.org/netdev/net/c/1e20904e4177

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html