2022-07-16 19:35:32

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 2/6] dt-bindings: firmware: scm: Add compatible for SM6375

Add a SCM compatible for SM6375.

Signed-off-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
index b3f702cbed87..de7bb8b8d85e 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
@@ -35,6 +35,7 @@ Required properties:
* "qcom,scm-sm8250"
* "qcom,scm-sm8350"
* "qcom,scm-sm8450"
+ * "qcom,sm6375-scm"
and:
* "qcom,scm"
- clocks: Specifies clocks needed by the SCM interface, if any:
--
2.37.0


2022-07-18 14:35:58

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/6] dt-bindings: firmware: scm: Add compatible for SM6375

On 16/07/2022 21:32, Konrad Dybcio wrote:
> Add a SCM compatible for SM6375.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> index b3f702cbed87..de7bb8b8d85e 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> @@ -35,6 +35,7 @@ Required properties:
> * "qcom,scm-sm8250"
> * "qcom,scm-sm8350"
> * "qcom,scm-sm8450"
> + * "qcom,sm6375-scm"

Uh, I think we wanted to keep it consistent with existing ones, didn't we?


Best regards,
Krzysztof

2022-07-18 14:37:39

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/6] dt-bindings: firmware: scm: Add compatible for SM6375



On 18.07.2022 16:29, Krzysztof Kozlowski wrote:
> On 16/07/2022 21:32, Konrad Dybcio wrote:
>> Add a SCM compatible for SM6375.
>>
>> Signed-off-by: Konrad Dybcio <[email protected]>
>> ---
>> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
>> index b3f702cbed87..de7bb8b8d85e 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
>> @@ -35,6 +35,7 @@ Required properties:
>> * "qcom,scm-sm8250"
>> * "qcom,scm-sm8350"
>> * "qcom,scm-sm8450"
>> + * "qcom,sm6375-scm"
>
> Uh, I think we wanted to keep it consistent with existing ones, didn't we?
>
I still haven't sent DT yet (need to get drivers in first), so I can do either,
though I thought it would be good practice to switch to the now-preferred
format and not have to add any more compatibles to the exception list.
>
> Best regards,
> Krzysztof