Document the availability of an LPG configuration for the PM660L PMIC in
the Qualcomm Light Pulse Generator driver.
Signed-off-by: Marijn Suijten <[email protected]>
Acked-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 409a4c7298e1..cd02811583ec 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -17,6 +17,7 @@ description: >
properties:
compatible:
enum:
+ - qcom,pm660l-lpg
- qcom,pm8150b-lpg
- qcom,pm8150l-lpg
- qcom,pm8350c-pwm
--
2.36.1
The Light Pulse Generator describes a hardware block responsible for
displaying colors and patterns on an RGB LED (usually used for [battery]
status and notifications), and drive PWM signals for general-purpose
(ie. backlight) LEDs. The availability and usage of the individual
channels differ per board and is hence left for individual platform DTs
to configure.
Signed-off-by: Marijn Suijten <[email protected]>
---
arch/arm64/boot/dts/qcom/pm660l.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
index cfef42353611..636b8d398d96 100644
--- a/arch/arm64/boot/dts/qcom/pm660l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
@@ -65,6 +65,15 @@ pmic@3 {
#address-cells = <1>;
#size-cells = <0>;
+ pm660l_lpg: lpg@b100 {
+ compatible = "qcom,pm660l-lpg";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+ };
+
pm660l_wled: leds@d800 {
compatible = "qcom,pm660l-wled";
reg = <0xd800 0xd900>;
--
2.36.1
On Wed 11 May 14:07 CDT 2022, Marijn Suijten wrote:
> Document the availability of an LPG configuration for the PM660L PMIC in
> the Qualcomm Light Pulse Generator driver.
>
> Signed-off-by: Marijn Suijten <[email protected]>
> Acked-by: Rob Herring <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
Regards,
Bjorn
> ---
> Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> index 409a4c7298e1..cd02811583ec 100644
> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> @@ -17,6 +17,7 @@ description: >
> properties:
> compatible:
> enum:
> + - qcom,pm660l-lpg
> - qcom,pm8150b-lpg
> - qcom,pm8150l-lpg
> - qcom,pm8350c-pwm
> --
> 2.36.1
>
On Wed, 11 May 2022 21:07:15 +0200, Marijn Suijten wrote:
> Document the availability of an LPG configuration for the PM660L PMIC in
> the Qualcomm Light Pulse Generator driver.
>
>
Applied, thanks!
[3/4] arm64: dts: qcom: pm660l: Add LPG node
commit: fc41893fe8289967d0aaffab25d8bb96334cc676
[4/4] arm64: dts: qcom: sdm630-nile: Add RGB status LED on the PM660L LPG
commit: dd764e1a42367c93d1e8e3f9e1ce08752a6dbac2
Best regards,
--
Bjorn Andersson <[email protected]>
On 5/12/22 12:37 AM, Marijn Suijten wrote:
> Document the availability of an LPG configuration for the PM660L PMIC in
> the Qualcomm Light Pulse Generator driver.
>
> Signed-off-by: Marijn Suijten <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> index 409a4c7298e1..cd02811583ec 100644
> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> @@ -17,6 +17,7 @@ description: >
> properties:
> compatible:
> enum:
> + - qcom,pm660l-lpg
> - qcom,pm8150b-lpg
> - qcom,pm8150l-lpg
> - qcom,pm8350c-pwm
This patch seems to have slipped through the cracks, as running a
'make dtbs_check' currently on linux-next tip causes the following issue:
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dtb:0:0:
/soc/spmi@800f000/pmic@3/lpg@b100:
failed to match any schema with compatible: ['qcom,pm660l-lpg']
If it helps:
Reviewed-by: Bhupesh Sharma <[email protected]>
Thanks.
On 2022-07-19 02:35:50, Bhupesh Sharma wrote:
>
> On 5/12/22 12:37 AM, Marijn Suijten wrote:
> > Document the availability of an LPG configuration for the PM660L PMIC in
> > the Qualcomm Light Pulse Generator driver.
> >
> > Signed-off-by: Marijn Suijten <[email protected]>
> > Acked-by: Rob Herring <[email protected]>
> > ---
> > Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > index 409a4c7298e1..cd02811583ec 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > @@ -17,6 +17,7 @@ description: >
> > properties:
> > compatible:
> > enum:
> > + - qcom,pm660l-lpg
> > - qcom,pm8150b-lpg
> > - qcom,pm8150l-lpg
> > - qcom,pm8350c-pwm
>
>
> This patch seems to have slipped through the cracks, as running a
>
> 'make dtbs_check' currently on linux-next tip causes the following issue:
>
> arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dtb:0:0:
> /soc/spmi@800f000/pmic@3/lpg@b100:
> ? failed to match any schema with compatible: ['qcom,pm660l-lpg']
>
> If it helps:
>
> Reviewed-by: Bhupesh Sharma <[email protected]>
Thanks. It is not only this patch but also the accompanying driver
change; both have to go through the leds tree. Bjorn already picked the
DTS patches as they have to go through the Qcom DTS tree.
I've resent a rebased v4, solving some context markers jumping to
different lines and dropping applied patches to hopefully make it clear
that only these are outstanding. Feel free to submit your Reviewed-by:
to the driver patch as well in hopes of making it in with the DTS
changes for 5.20:
https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t
Thanks!
- Marijn