2022-08-03 06:38:23

by Yajun Deng

[permalink] [raw]
Subject: [PATCH 5.10-rt] locking/rtmutex: switch to EXPORT_SYMBOL() for ww_mutex_lock{,_interruptible}()

We can use EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL() in
ww_mutex_lock_interruptible() and ww_mutex_lock(). That match
ww_mutex_unlock() well. And also good for 3rd kernel modules.

Signed-off-by: Yajun Deng <[email protected]>
---
kernel/locking/rtmutex.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index 31b374d36d04..b110fc57f733 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -2513,7 +2513,7 @@ ww_mutex_lock_interruptible(struct ww_mutex *lock, struct ww_acquire_ctx *ctx)

return ret;
}
-EXPORT_SYMBOL_GPL(ww_mutex_lock_interruptible);
+EXPORT_SYMBOL(ww_mutex_lock_interruptible);

int __sched
ww_mutex_lock(struct ww_mutex *lock, struct ww_acquire_ctx *ctx)
@@ -2533,7 +2533,7 @@ ww_mutex_lock(struct ww_mutex *lock, struct ww_acquire_ctx *ctx)

return ret;
}
-EXPORT_SYMBOL_GPL(ww_mutex_lock);
+EXPORT_SYMBOL(ww_mutex_lock);

void __sched ww_mutex_unlock(struct ww_mutex *lock)
{
--
2.25.1



Subject: Re: [PATCH 5.10-rt] locking/rtmutex: switch to EXPORT_SYMBOL() for ww_mutex_lock{,_interruptible}()

On 2022-08-03 14:24:30 [+0800], Yajun Deng wrote:
> We can use EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL() in
> ww_mutex_lock_interruptible() and ww_mutex_lock(). That match
> ww_mutex_unlock() well. And also good for 3rd kernel modules.

Not that I am fan of this but it will sync the symbols with what landed
upstream as of commit
f8635d509d807 ("locking/ww_mutex: Implement rtmutex based ww_mutex API functions")

therefore it would be good to have.
Luis?

> Signed-off-by: Yajun Deng <[email protected]>

Sebastian

Subject: Re: [PATCH 5.10-rt] locking/rtmutex: switch to EXPORT_SYMBOL() for ww_mutex_lock{,_interruptible}()

On Thu, Aug 18, 2022 at 06:32:37PM +0200, Sebastian Andrzej Siewior wrote:
> On 2022-08-03 14:24:30 [+0800], Yajun Deng wrote:
> > We can use EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL() in
> > ww_mutex_lock_interruptible() and ww_mutex_lock(). That match
> > ww_mutex_unlock() well. And also good for 3rd kernel modules.
>
> Not that I am fan of this but it will sync the symbols with what landed
> upstream as of commit
> f8635d509d807 ("locking/ww_mutex: Implement rtmutex based ww_mutex API functions")
>
> therefore it would be good to have.
> Luis?

Looks good to me. I can add that to my next update.

Luis

> > Signed-off-by: Yajun Deng <[email protected]>
>
> Sebastian
>
---end quoted text---