2022-08-05 09:34:19

by Johan Hovold

Subject: [PATCH 1/7] arm64: dts: qcom: sc8280xp-crd: disable touchscreen pull-up

The touchscreen interrupt line has an external pull-up so disable the
internal one as is done for the keyboard and touchpad.

Signed-off-by: Johan Hovold <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index 6792e88b2c6c..47192e9cf7a4 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -405,7 +405,7 @@ ts0_default: ts0-default-state {
int-n {
pins = "gpio175";
function = "gpio";
- bias-pull-up;
+ bias-disable;
};

reset-n {
--
2.35.1

2022-08-06 16:58:02

by Manivannan Sadhasivam

Subject: Re: [PATCH 1/7] arm64: dts: qcom: sc8280xp-crd: disable touchscreen pull-up

On Fri, Aug 05, 2022 at 11:23:11AM +0200, Johan Hovold wrote:
> The touchscreen interrupt line has an external pull-up so disable the
> internal one as is done for the keyboard and touchpad.
>
> Signed-off-by: Johan Hovold <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index 6792e88b2c6c..47192e9cf7a4 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -405,7 +405,7 @@ ts0_default: ts0-default-state {
> int-n {
> pins = "gpio175";
> function = "gpio";
> - bias-pull-up;
> + bias-disable;
> };
>
> reset-n {
> --
> 2.35.1
>

--
மணிவண்ணன் சதாசிவம்